Date: Mon, 1 Mar 2004 17:02:46 -0500 (EST) From: Josh Elsasser <jre@vineyard.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/63618: PATCH: fix segfault in games/heroes Message-ID: <20040301220246.9C9ADAF@jade.elsasser.org> Resent-Message-ID: <200403012210.i21MAFip081023@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 63618
>Category: ports
>Synopsis: PATCH: fix segfault in games/heroes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 01 14:10:15 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Josh Elsasser
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD jade.elsasser.org 5.2-CURRENT FreeBSD 5.2-CURRENT #11: Sat Feb 7 15:09:05 EST 2004 joshe@jade.elsasser.org:/usr/local/obj/usr/src/sys/JADE i386
>Description:
Heroes 0.21 contains an unterminated array which can cause segfaults.
The simple one-line fix is in CVS, and will be included if they ever
get around to releasing a new version.
Also pass --disable-ggi to the configure script, which prevents it
from using libggi instead of libsdl if libggi happens to be installed.
Make myself maintainer as it doesn't seem to have one.
>How-To-Repeat:
>Fix:
Note that this patch creates the file patch-src::menus.c
diff -u -rN /usr/ports/games/heroes/Makefile heroes/Makefile
--- /usr/ports/games/heroes/Makefile Thu Feb 5 06:36:51 2004
+++ heroes/Makefile Mon Mar 1 16:47:29 2004
@@ -7,7 +7,7 @@
PORTNAME= heroes
PORTVERSION= 0.21
-PORTREVISION= 3
+PORTREVISION= 4
CATEGORIES= games
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= ${PORTNAME}
@@ -18,7 +18,7 @@
#PATCH_SITES= ftp://heroes.sourceforge.net/pub/heroes/patches/
#PATCHFILES= heroes-0.7-errata.patch
-MAINTAINER= ports@FreeBSD.org
+MAINTAINER= jre@vineyard.net
COMMENT= A game of yore similar to the "Tron" and "Nibbles"
LIB_DEPENDS= iconv.3:${PORTSDIR}/converters/libiconv
@@ -41,7 +41,7 @@
CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" \
MAKEINFO="makeinfo --no-split"
-CONFIGURE_ARGS= --with-sdl_mixer=${LOCALBASE} --without-gii
+CONFIGURE_ARGS= --with-sdl_mixer=${LOCALBASE} --without-gii --without-ggi
MAN6= heroes.6 heroeslvl.6
INFO= heroes
diff -u -rN /usr/ports/games/heroes/files/patch-src::menus.c heroes/files/patch-src::menus.c
--- /usr/ports/games/heroes/files/patch-src::menus.c Wed Dec 31 19:00:00 1969
+++ heroes/files/patch-src::menus.c Mon Mar 1 16:48:45 2004
@@ -0,0 +1,12 @@
+--- src/menus.c.orig Mon Jan 14 17:13:59 2002
++++ src/menus.c Mon Mar 1 16:25:56 2004
+@@ -219,7 +219,8 @@
+ { N_("NEW LEVEL"), editor_menu },
+ /* TRANS: Load an existing level for edition. */
+ { N_("LOAD LEVEL"), editor_selector },
+- { N_("GO BACK"), 0 }
++ { N_("GO BACK"), 0 },
++ { 0, 0 }
+ };
+
+ a_menu *editor_menu_data;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040301220246.9C9ADAF>