From owner-cvs-all Tue Dec 18 14:53:47 2001 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id BB1EA37B405; Tue, 18 Dec 2001 14:53:41 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id fBIMrea18414; Tue, 18 Dec 2001 15:53:40 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id fBIMrdM92149; Tue, 18 Dec 2001 15:53:40 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200112182253.fBIMrdM92149@harmony.village.org> To: John Baldwin Subject: Re: cvs commit: src/sys/isa fd.c Cc: Joerg Wunsch , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org In-reply-to: Your message of "Tue, 18 Dec 2001 14:36:07 PST." References: Date: Tue, 18 Dec 2001 15:53:39 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message John Baldwin writes: : On 18-Dec-01 Joerg Wunsch wrote: : > joerg 2001/12/18 14:16:33 PST : > : > Modified files: : > sys/isa fd.c : > Log: : > Change the test for _MACHINE_ARCH == i386 into #ifdef __i386__ since it : > otherwise breaks on the Alpha arch. I think this is wrong since i'd : > actually like to probe for a PC architecture, not for a particular CPU : > type. Anyway, now it's again the way it used to be. : : i386 is the architecture name we use. I386_CPU is for a particular CPU. __i386__ is defined on both FreeBSD/i386 and FreeBSD/pc98. There's no unique symbole for FreeBSD/i386, so that should be #if defined(__i386__) && !defined(PC98) if you want it only on PC-AT machines. However, for this file, it is moot since it isn't used on pc98 (pc98 has its own driver for fd, iirc). Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message