Date: Mon, 15 Sep 1997 01:30:08 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com> To: bde@zeta.org.au (Bruce Evans) Cc: bde@zeta.org.au, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-user@FreeBSD.ORG, rgrimes@FreeBSD.ORG Subject: Re: cvs commit: src Makefile Message-ID: <199709150830.BAA02397@GndRsh.aac.dev.com> In-Reply-To: <199709150805.SAA05669@godzilla.zeta.org.au> from Bruce Evans at "Sep 15, 97 06:05:58 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> >> > Log: > >> > When calling the src/include Makefile use the shorthand ``all beforeinstall'' > >> > inplace of ``all installhdrs symlinks'' so those of us who run with > >> > SHARED=copies get the right results. > >> > >> This just undoes rev.1.136 and defeats the point of the installhdrs target, > >> which is to support `make install' forcing installation of symlinks here > >> (for the temporary include directory for `make world'). > >> > >> SHARED=copies is the default. > > > >No, it does not do that. Take a very careful look, the forcing of > > Yes it does. Of course I looked carefully before commenting. You broke > the main `includes' target. No, I fixed the main ``includes'' target, rev 1.136 broke it. Remeber I wrote the original, I maintaine dfor the first 2 years, it should NOT forceably do a ``make symlinks'' as it did. If something is broken, it is elsewhere. > > >the symlinks for the temporary includes occurs someplace else, namely > >in the ``bootstrap:'' which still has the call to ``symlinks'', which > >DTRT. > > The `bootstrap' target only installs very temporary (and not quite right) > includes, just enough to build the bootstrap tools. The `includes' > target is built a little later. This must use symlinks so that the > header times don't change for the NOCLEAN case. (`make bootstrap' > has blown away any files installed by a previous run with SHARED=copies. > The !NOCLEAN case isn't important since everything gets blown away > anyway.) > > >revision1.136 broke work that was done over 4 years ago, and until > > It only broke the undocumented internal `includes' target. Includes is _not_, and never was an internal target, or I would have called it _includes when I wrote it. > > >then had worked correctly, I just made it work again. As things > >where _all_ systems ended up with links in /usr/include if they > >ran ``make includes''. > > Don't use undocumented internal targets. Another breakage, it was documented at one time. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation, Inc. Reliable computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709150830.BAA02397>