From nobody Tue Sep 13 21:45:59 2022 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRxqD1XtRz4cXCY for ; Tue, 13 Sep 2022 21:46:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRxqD0G0pz3gx4 for ; Tue, 13 Sep 2022 21:46:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MRxqC6KnlzSNc for ; Tue, 13 Sep 2022 21:45:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 28DLjxg5074581 for ; Tue, 13 Sep 2022 21:45:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 28DLjxKr074580 for x11@FreeBSD.org; Tue, 13 Sep 2022 21:45:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 266227] [exp-run] Request for exp-run with qsort_r API change Date: Tue, 13 Sep 2022 21:45:59 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: delphij@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: exp-run? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663105560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2weYCSBxfcxKOVXeMvIMxQnDz9TW6VatTEBUZj62ozM=; b=kK+t+43JrAxujBfmWCQtp5+wD4KXBaWxRX3sxWLdTGm7UxbfHilhJihOXmUmRvf3zgPcFj fFb1H3/vFaNhI/CWCn9e8j5k1klRT9WjeJbce/VOhCq3B1goS9irf9ZgCK3C88JcL4n/HF /3lI2wpVxG15th9iAJ3s7YCDGd+PTLPxK37yzve9wdqtExWhGC8+ygrSimrxu79/klkLFZ GZ1Fv8MZQcZHsaYmSJ7vx98Chix2JgSUjG4Tiru0JmHgQ9CmJ4fZC2AOh15rbwnltEp9iw TCMlWHMvhWOQuDwll3AWCiArQiDz7a8sBbMTW5e4JXjRyln7YAd3A8O1khbDRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663105560; a=rsa-sha256; cv=none; b=u3prn8M7Fj0SB1Pkd6wWN3KY2BhBp/yrDOPvf4HII7avRfQG/zcswrw/NFtDlGeAgC3qzo giPbLmUKBv15pgll64V/L6tCYfNC4tVdSQ/mn82dpzF18pOX3GMVPdEmqJaWJ9ot8xuK8r CeY2PPy+GaQA3tx6UsKks896MRWN6E/Em9ozP2E2jL7PKNk/oFremFeuIzlAb3Cptc7g22 488Xmc7Zf6VC5LW4kYcKbqacrnADMQuk4h6eMl5GKVgaJz7BFs9RKAXVmTNjtC6UxXMMAI 0CKcOF5c4fss9ipQGqivV51FYajrC41omcLCCM9gnpIGyK/uer4TA3UQic/Ing== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266227 --- Comment #20 from Xin LI --- (In reply to Matthias Andree from comment #19) > e2fsprogs - I am scratching my head over this, especially over the detect= ion=20 > and the "defined qsort_r" part gives me the creeps. It nicely shows the=20 > distress to tell one qsort_r interface from another. I agree. This is meant to be a stop-gap solution: once the change of qsort= _r landed, we will have a new __FreeBSD_version which can be used for the detection. Another potentially better solution would be to have the configure script t= o: 1. Detect if there is a qsort_r, and 2. When it does, have two C programs with "#include " followed by= BSD and GNU definition signatures, and compile; if the compilation succeeded, t= he corresponding variant was used and define HAVE_{GNU,BSD}_QSORT_R accordingl= y. And change the code to use the HAVE_{GNU,BSD}_QSORT_R definition. > Besides that, the qsort_r standardization attempt is ill-advised. C11 alr= eady > has qsort_s (but it apparently has not made it into POSIX 2018) and I won= der > where GNU libc's implementation is... Fedora 36 apparently does not carry= one, > and rather than standardizing on an implementation that is behind, they b= less > qsort_r()? Wow.=20 Well, the crazy part of qsort_s is that the Microsoft version (https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/qsort-s?v= iew=3Dmsvc-170) is also slightly, but incompatibly different from C11 qsort_s. We have ado= pted the C11 signature. > Do we really need to jump the gun? What are our FreeBSD 14 and the POSIX > schedules, will we have all the other things in place when we flip the sw= itch > for qsort_r to use the GNU API? I think yes. It's clear that the GNU API have been adopted by more software nowadays. T= he problem was created by glibc maintainers, yes, and I don't like their API either, but making software developer's life easier on FreeBSD would benefi= t us more in long term. --=20 You are receiving this mail because: You are on the CC list for the bug.=