From owner-cvs-all@FreeBSD.ORG Tue Oct 25 17:19:41 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA56C16A422; Tue, 25 Oct 2005 17:19:40 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 78DD743D5A; Tue, 25 Oct 2005 17:19:39 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Tue, 25 Oct 2005 13:36:22 -0400 From: John Baldwin To: Kris Kennaway Date: Tue, 25 Oct 2005 13:16:07 -0400 User-Agent: KMail/1.8.2 References: <200510242104.j9OL4J2B045827@repoman.freebsd.org> <20051025164222.GB16812@xor.obsecurity.org> In-Reply-To: <20051025164222.GB16812@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510251316.08672.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_kdb.c subr_smp.c src/sys/amd64/amd64 mp_machdep.c trap.c src/sys/amd64/conf NOTES src/sys/amd64/include smp.h src/sys/conf options.amd64 options.i386 options.pc98 src/sys/i386/conf NOTES src/sys/i386/i386 mp_machdep.c trap.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2005 17:19:41 -0000 On Tuesday 25 October 2005 12:42 pm, Kris Kennaway wrote: > On Mon, Oct 24, 2005 at 09:04:19PM +0000, John Baldwin wrote: > > jhb 2005-10-24 21:04:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_kdb.c subr_smp.c > > sys/amd64/amd64 mp_machdep.c trap.c > > sys/amd64/conf NOTES > > sys/amd64/include smp.h > > sys/conf options.amd64 options.i386 options.pc98 > > sys/i386/conf NOTES > > sys/i386/i386 mp_machdep.c trap.c > > sys/i386/include smp.h > > sys/pc98/conf NOTES > > sys/sys smp.h > > Log: > > Rename the KDB_STOP_NMI kernel option to STOP_NMI and make it apply to > > all IPI_STOP IPIs. > > I thought we were going to make KDB_STOP_NMI the default (since it's > necessary to avoid hangs on panic on SMP machines). That seems like > it's more risky now that it's bound up with other code. Well, the MI parts of KDB_STOP_NMI (using stoppedpcbs[] on x86) now is the default. All this does is make it so that all IPI_STOP IPIs (such as those used during shutdown, which is currently the only use outside of KDB) are able to use NMIs now. Also, it makes it simpler to enable stoppedpcbs[] on other archs like sparc64. If you want to turn STOP_NMI on by default that would be fine with me. The NMIs can still be disabled via sysctl/tunable even with the option on. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org