From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 16:53:22 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC2AF1065679; Sat, 24 Dec 2011 16:53:22 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 7414D8FC0C; Sat, 24 Dec 2011 16:53:22 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBOGmcLE012313 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sat, 24 Dec 2011 09:48:38 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Sat, 24 Dec 2011 09:48:37 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> To: Chris Rees X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sat, 24 Dec 2011 09:48:38 -0700 (MST) Cc: Maxim Ignatenko , freebsd-rc@FreeBSD.org Subject: Re: conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 16:53:22 -0000 On Dec 24, 2011, at 6:15 AM, Chris Rees wrote: > On 24 December 2011 12:30, Maxim Ignatenko = wrote: >> The following reply was made to PR conf/163508; it has been noted by = GNATS. >>=20 >> From: Maxim Ignatenko >> To: Doug Barton >> Cc: bug-followup@freebsd.org >> Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" = and >> "disable" commands to rc.subr >> Date: Sat, 24 Dec 2011 14:20:19 +0200 >>=20 >> On 24 December 2011 04:15, Doug Barton wrote: >> > This idea has been considered before and rejected because it's too >> > difficult to catch all the corner cases, and actually editing a = config >> > file is not really all that hard of a thing to do. >> > >>=20 >> The idea was to make enabling/disabling services less error-prone. = It >> don't need to catch _all_ corner cases, because if administrator do >> something unusual with startup configuration he should be able to >> manipulate it in proper way, or even have tools that do something >> similar. >> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and >> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% = of >> cases. >> Doing `service someserive enable` is much faster and less = error-prone >> that `service someservice rcvar ; echo someservicercvar_enable=3DYES = >> >> /etc/rc.conf` >=20 > Disagree, sorry. >=20 > If we're going to implement these ideas we should do it properly, not > for 95% of cases. A lot depends on what those 5% of the cases are. Absent an = implementation to throw stones at, such criticism is premature. If the = 5% of cases are when someone has done something complicated to the = rc.conf file, then I don't care: they won't use this interface and we = can detect this case and do nothing. If the 5% of the cases are when = someone has enabled ntpd, then that would be a non-starter. Warner=