From owner-freebsd-rc@FreeBSD.ORG Fri May 14 04:15:28 2010 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED7C9106564A for ; Fri, 14 May 2010 04:15:28 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id 9B45F8FC13 for ; Fri, 14 May 2010 04:15:28 +0000 (UTC) Received: (qmail 12633 invoked by uid 399); 14 May 2010 04:15:27 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 May 2010 04:15:27 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BECCE5D.1060308@FreeBSD.org> Date: Thu, 13 May 2010 21:15:25 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100330 Thunderbird/3.0.4 MIME-Version: 1.0 To: freebsd-rc@FreeBSD.org X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Patch for early rc.d scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 04:15:29 -0000 The patch at http://people.freebsd.org/~dougb/early-rc.diff does the following for the scripts that run up till FILESYSTEMS (the default early_late_divider): 1. Move as many BEFOREs to REQUIREs as possible. 2. Move sysctl to run first 3. Minor effect, move hostid_save from right before mdconfig to right after. My original purpose for working on this was that while doing some debugging on other stuff I noticed that the order of execution was different in the first pass through the early scripts and the second. In practice that doesn't matter because the scripts are not executed the second time. However this _can_ result in problems if the difference in the rcorder moves a script from the late section to the early section in the second pass (which would mean the script would not get executed). So, I wanted to make the order of execution of the scripts in the early section deterministic. In the course of debugging the ordering problems I noticed that moving the BEFOREs to REQUIREs prevented the changes in order from the first pass to the second pass without having to make any other changes. (Of course it's no secret that I think BEFORE should be avoided as much as possible, but this is a good example of why.) The one substantial change I made is run sysctl first. A lot of the early scripts make use of sysctl one way or another. Running this first makes a lot of sense to me given that system-critical values are often placed in sysctl.conf, and I can't see any downsides. Please let me know if I've missed something. Please review my work, and let me know if you see any problems. I don't regard this as urgent, but I would like to get it in within the next week. Regards, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/