Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Sep 2019 23:12:07 +0000 (UTC)
From:      "Jayachandran C." <jchandra@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r352499 - stable/12/sys/arm64/arm64
Message-ID:  <201909182312.x8INC7OW065494@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jchandra
Date: Wed Sep 18 23:12:07 2019
New Revision: 352499
URL: https://svnweb.freebsd.org/changeset/base/352499

Log:
  MFC r348291:
  
  arm64 nexus: remove incorrect warning
  
  acpi_config_intr() will be called when an arm64 system booted with ACPI.
  We do the interrupt mapping for ACPI interrupts in nexus_acpi_map_intr()
  on arm64, so acpi_config_intr() has to just return success without
  printing this error message.
  
  Reviewed by:	andrew
  Differential Revision:	https://reviews.freebsd.org/D19432

Modified:
  stable/12/sys/arm64/arm64/nexus.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/arm64/arm64/nexus.c
==============================================================================
--- stable/12/sys/arm64/arm64/nexus.c	Wed Sep 18 23:08:51 2019	(r352498)
+++ stable/12/sys/arm64/arm64/nexus.c	Wed Sep 18 23:12:07 2019	(r352499)
@@ -292,9 +292,11 @@ nexus_config_intr(device_t dev, int irq, enum intr_tri
     enum intr_polarity pol)
 {
 
-	/* TODO: This is wrong, it's needed for ACPI */
-	device_printf(dev, "bus_config_intr is obsolete and not supported!\n");
-	return (EOPNOTSUPP);
+	/*
+	 * On arm64 (due to INTRNG), ACPI interrupt configuration is 
+	 * done in nexus_acpi_map_intr().
+	 */
+	return (0);
 }
 
 static int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909182312.x8INC7OW065494>