From owner-freebsd-rc@FreeBSD.ORG Tue Oct 6 16:50:10 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E42F106566B; Tue, 6 Oct 2009 16:50:10 +0000 (UTC) (envelope-from dhorn2000@gmail.com) Received: from mail-yx0-f171.google.com (mail-yx0-f171.google.com [209.85.210.171]) by mx1.freebsd.org (Postfix) with ESMTP id A68018FC16; Tue, 6 Oct 2009 16:50:09 +0000 (UTC) Received: by yxe1 with SMTP id 1so4282160yxe.3 for ; Tue, 06 Oct 2009 09:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dGVFPnc66mWnoCI7HnfG3Ykb7sBDfpkZpLA3MebaMrY=; b=W3tcF4U9OgLjD2COTu60BrKaHknVcybbsOeX5IlcfQVk+CizZcICIRDDNHCMOWbA1x rI6wYRXl41Dbt6KWtSZq5/ZfC0jmp4L2CTgBy61yaDcFfT6IPIoMlrV5YuxyBuLjSEVt kHiXNc/03kWemxWYobjkKTIwxuLGacUnBdn3k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QsGKUrKx9lSvAPWjg8pLzouP2Y35GfWsGW+MUoBNL461/rbfahcd+T+a7IgCNG4nsA ysGUNIBp0zk4LavHdKHK6746h8rpajIasU+ja/J+M3Yr4ziZCMOEBT6PovJtQZ8xc8NN A37kmLwEN7ZBPmJuFX58Ai9qCd/mYFibKsvac= MIME-Version: 1.0 Received: by 10.100.24.37 with SMTP id 37mr1744227anx.45.1254846065545; Tue, 06 Oct 2009 09:21:05 -0700 (PDT) In-Reply-To: <4ACB3A08.9030109@andric.com> References: <200909122222.n8CMMV3d099311@svn.freebsd.org> <4AB15FCE.70505@FreeBSD.org> <20090920.224018.16368211.hrs@allbsd.org> <20091005.123427.227628092.hrs@allbsd.org> <4ACA4B81.3090105@andric.com> <4ACB3A08.9030109@andric.com> Date: Tue, 6 Oct 2009 12:21:05 -0400 Message-ID: <25ff90d60910060921k2118994aq1f5b0431868ec800@mail.gmail.com> From: David Horn To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-rc@freebsd.org Subject: Re: nd6 change and rc.d/network_ipv6 -> rc.d/netif integration X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2009 16:50:10 -0000 On Tue, Oct 6, 2009 at 8:37 AM, Dimitry Andric wrote: > On 2009-10-05 21:39, Dimitry Andric wrote: >>> =A0 http://people.freebsd.org/~hrs/ipv6_stable8.20091005.diff >> Hmm, build bombs out at sbin/ifconfig: > ... >> This is because the patch doesn't seem to contain >> sbin/ifconfig/af_nd6.c. =A0Can I just use the version from head? > > FYI, the patch also misses etc/rc.d/{faith,stf}. =A0Without these, > mergemaster fails; again, taking them from head fixes it. Hiroki -- I also attempted to use your patch against 8/Stable svn, and wanted to give some feedback. svn add before doing the svn diff will ensure that files you want to add to a patch get noticed. svn diff will only look at files under version control. 1) Patchset is missing examples and defaults for new rc.conf variables to /etc/defaults/rc.conf. (The defaults/rc.conf has been updated in -current, although perhaps once everything settles, it would help to expand the examples in comments) 2) I really like the changes to ifconfig and kernel for exposing per-interface flags for "accept_rtadv" and other ndp flags to ifconfig (and inherently rc.conf). I previously had to do some hackery to disable "accept_rtadv" at boot time for just one interface within rc.conf. 3) I would prefer that ipv6_enable remain a global flag in rc.conf, and NOT be obsoleted. I would also prefer that ipv6_network_interfaces=3D"auto" as in the past by default. Again, I like the logic changes and the flexibility it provides, it is just the default/obsolete that I am interested in changing. 4) Personal opinion time: change the "accept_rtadv" token to "autoconf" in ifconfig and rc.conf, as this it is a better self-description. Just one persons opinion. 5) I noticed in the comments that you are considering allowing autoconf+router in a future advanced configuration. I completely agree with adding this functionality to -current (for ipv6 router cpe needs), we just need a new knob when this gets added. I had code around somewhere at one point. I'll see if I can find it still. There is a PR (conf/121812) on this as well. Given the timing, +1 for letting this bake in -current until after 8.0 release. If you want any early feedback for a future MFC of this code, feel free to email me and I will gladly test the patch. Thanks for the changes. ---Dave H