From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jul 26 12:46:36 2009 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 651C2106566B; Sun, 26 Jul 2009 12:46:36 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from fallbackmx06.syd.optusnet.com.au (fallbackmx06.syd.optusnet.com.au [211.29.132.8]) by mx1.freebsd.org (Postfix) with ESMTP id E5B098FC24; Sun, 26 Jul 2009 12:46:35 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail35.syd.optusnet.com.au (mail35.syd.optusnet.com.au [211.29.133.51]) by fallbackmx06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n6QAgQ58000867; Sun, 26 Jul 2009 20:42:26 +1000 Received: from server.vk2pj.dyndns.org (c122-106-216-251.belrs3.nsw.optusnet.com.au [122.106.216.251]) by mail35.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n6QAgMUD011684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 26 Jul 2009 20:42:23 +1000 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id n6QAgLm0011145; Sun, 26 Jul 2009 20:42:21 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id n6QAgLK1011144; Sun, 26 Jul 2009 20:42:21 +1000 (EST) (envelope-from peter) Date: Sun, 26 Jul 2009 20:42:21 +1000 From: Peter Jeremy To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org Message-ID: <20090726104221.GA11110@server.vk2pj.dyndns.org> References: <200902211153.n1LBrt7F048954@server.vk2pj.dyndns.org> <200902211200.n1LC062l032521@freefall.freebsd.org> <20090518112643.GA48097@server.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <20090518112643.GA48097@server.vk2pj.dyndns.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.19 (2009-01-05) Cc: Subject: Re: ports/131930: [PATCH] x11-servers/xorg-server coredumps on exit X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 12:46:36 -0000 --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2009-May-18 21:26:43 +1000, Peter Jeremy = wrote: >I am no longer able to reproduce the core-dump on a stock >xorg-server-1.6.1,1 so I believe the problem has been resolved >upstream (though in a different fashion to my patch). Looks like I spoke too soon. After my latest upgrade on an 8-current netbook (i386 with i915), the core-dump-on-exit problem re-appeared until I re-applied an updated version of the patch (see end). (This is a regression as it was working OK until my latest port upgrade). X-related ports list: damageproto-1.1.0_2 dri-7.4.4,2 dri2proto-2.0 expat-2.0.1 fixesproto-4.0 fontsproto-2.0.2 freetype2-2.3.9_1 gettext-0.17_1 inputproto-1.5.0 kbproto-1.0.3 libGL-7.4.4 libICE-1.0.4_1,1 libSM-1.1.0_1,1 libX11-1.2.1_1,1 libXau-1.0.4 libXaw-1.0.5_1,1 libXdamage-1.1.1 libXdmcp-1.0.2_1 libXext-1.0.5,1 libXfixes-4.0.3_1 libXfont-1.3.4,1 libXi-1.2.1,1 libXinerama-1.0.3,1 libXmu-1.0.4,1 libXp-1.0.0,1 libXpm-3.5.7 libXt-1.0.5_1 libXv-1.0.4,1 libXvMC-1.0.4_1 libXxf86misc-1.0.1 libXxf86vm-1.0.2 libdrm-2.4.11 libfontenc-1.0.4 libiconv-1.13.1 libpciaccess-0.10.6 libpthread-stubs-0.1 libxcb-1.3 libxkbfile-1.0.5 libxkbui-1.0.2_1 pciids-20090224 pixman-0.15.4 pkg-config-0.23_1 printproto-1.0.4 python25-2.5.4_2 videoproto-2.2.2 xcb-proto-1.5 xextproto-7.0.5 xf86miscproto-0.9.2 xf86vidmodeproto-2.2.2 xineramaproto-1.1.2 xkeyboard-config-1.6_1 xorg-server-1.6.1_1,1 xproto-7.0.15 Unfortunately, the original patch no longer applies. A revised patch is: --- dix/window.c~ 2009-04-15 03:14:56.000000000 +1000 +++ dix/window.c 2009-07-26 20:13:11.257430828 +1000 @@ -963,7 +963,11 @@ } xfree(dixLookupPrivate(&pWin->devPrivates, FocusPrivatesKey)); dixFreePrivates(pWin->devPrivates); - xfree(pWin); + if (!pParent) { + pWin->devPrivates =3D NULL; + } else { + xfree(pWin); + } return Success; } =20 --=20 Peter Jeremy --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEYEARECAAYFAkpsMw0ACgkQ/opHv/APuIf49gCdF9UYuybIZuyx/Pi4waP9sKpE TKsAoJR540E9HPWylTNCn+mfOrJjYX/6 =wkAW -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--