From owner-freebsd-bugs@FreeBSD.ORG Mon Jul 7 12:30:05 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F8761065670 for ; Mon, 7 Jul 2008 12:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EC1808FC22 for ; Mon, 7 Jul 2008 12:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m67CU4BZ073954 for ; Mon, 7 Jul 2008 12:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m67CU41N073953; Mon, 7 Jul 2008 12:30:04 GMT (envelope-from gnats) Resent-Date: Mon, 7 Jul 2008 12:30:04 GMT Resent-Message-Id: <200807071230.m67CU41N073953@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Frank Behrens Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC6BC106564A for ; Mon, 7 Jul 2008 12:21:53 +0000 (UTC) (envelope-from frank@pinky.sax.de) Received: from post.frank-behrens.de (unknown [IPv6:2a01:170:1023::1:2]) by mx1.freebsd.org (Postfix) with ESMTP id 314DD8FC13 for ; Mon, 7 Jul 2008 12:21:52 +0000 (UTC) (envelope-from frank@pinky.sax.de) Received: from moon.behrens ([IPv6:2a01:170:1023::1:2]) by post.frank-behrens.de (8.14.2/8.14.2) with ESMTP-MSA id m67CLfB4040175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 7 Jul 2008 14:21:41 +0200 (CEST) (envelope-from frank@moon.behrens) Received: (from frank@localhost) by moon.behrens (8.14.2/8.14.2/Submit) id m67CLfhq040174; Mon, 7 Jul 2008 14:21:41 +0200 (CEST) (envelope-from frank) Message-Id: <200807071221.m67CLfhq040174@moon.behrens> Date: Mon, 7 Jul 2008 14:21:41 +0200 (CEST) From: Frank Behrens To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/125365: [patch] mdconfig(8) -l overflow for size field X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 12:30:05 -0000 >Number: 125365 >Category: bin >Synopsis: [patch] mdconfig(8) -l overflow for size field >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 07 12:30:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Frank Behrens >Release: FreeBSD 7.0-STABLE-200805150513 i386 >Organization: >Environment: >Description: mdconfig(8) shows with -l -v the size of configured device. For devices with size > ULONG_MAX no number is shown. >How-To-Repeat: Configute a bigger md device and show details: # cd /tmp # truncate -s 1G s.tmp # truncate -s 10G b.tmp # mdconfig -a -t vnode -f s.tmp -u 100 # mdconfig -a -t vnode -f b.tmp -u 101 # mdconfig -l -u 100 1.0G /tmp/s.tmp # mdconfig -l -u 101 /tmp/b.tmp # mdconfig -d -u 100 # mdconfig -d -u 101 # rm s.tmp b.tmp >Fix: --- mdconfig_overflow.patch begins here --- --- mdconfig.c.orig 2008-07-05 17:05:27.481413000 +0200 +++ mdconfig.c 2008-07-07 14:02:04.355862796 +0200 @@ -444,11 +444,11 @@ md_prthumanval(char *length) { char buf[6]; - uint64_t bytes; + unsigned long long bytes; char *endptr; - bytes = strtoul(length, &endptr, 10); - if (bytes == (unsigned)ULONG_MAX || *endptr != '\0') + bytes = strtoull(length, &endptr, 10); + if (bytes == (unsigned)ULLONG_MAX || *endptr != '\0') return; humanize_number(buf, sizeof(buf) - (bytes < 0 ? 0 : 1), bytes, "", HN_AUTOSCALE, HN_B | HN_NOSPACE | HN_DECIMAL); --- mdconfig_overflow.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: