From owner-svn-src-all@FreeBSD.ORG Tue Nov 29 00:33:03 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71B69106564A; Tue, 29 Nov 2011 00:33:03 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 54E538FC08; Tue, 29 Nov 2011 00:33:03 +0000 (UTC) Received: from delta.delphij.net (c-76-102-50-245.hsd1.ca.comcast.net [76.102.50.245]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id DFB876B6F; Mon, 28 Nov 2011 16:33:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1322526783; bh=sCx/DqFttzUGfJHnK8cHgEZj8DY/MvK5Ei+T9ApeKF8=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=AIOkHWttgGgzhB1SJvvUjcQYTzV8UNUqVw9niQY2v8pXrlT3S7XflWFtnuGbPtLL6 F6QI6zJFHUTh68DW9X1+wa9mX77pQDTmGX+RyrkqLXX1MWB/jDNhNFmmGzPmf74hn6 YnltJ3gLheG4r1D1mjn031g3/+8oxPrI+2NR2yN8= Message-ID: <4ED4283E.4040003@delphij.net> Date: Mon, 28 Nov 2011 16:33:02 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoW4=?= References: <201111282016.pASKGtcf007383@svn.freebsd.org> <4ED3ED83.9000001@delphij.net> <4ED42023.3080301@t-hosting.hu> In-Reply-To: <4ED42023.3080301@t-hosting.hu> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, d@delphij.net Subject: Re: svn commit: r228099 - head/usr.bin/grep X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2011 00:33:03 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/28/11 15:58, Gábor Kövesdán wrote: > On 2011.11.28. 21:22, Xin LI wrote: >> This is useful but could be confusing since xzgrep's behavior >> could be different from zgrep. > What do you refer to exactly? That zgrep is GNU grep and xzgrep is > BSD grep? I acknowledge that this is not documented but xzgrep is > a Yes. > non-standard addition so personally think it is acceptable. > Someone called my attention to the archivers/xz port that had a > wrapper script for grep, callled xzgrep. This was installed with > the port but is not installed in base any more so I got the > suggestion to implement it in BSD grep and I think it is a better > idea than a wrapper script and it was easy to support. So with this > change, this functionality can be used again w/o installing the > port although it is not documented. I'm not quite convinced but your reasoning do have something so let's keep it as-is for now, at least. Eventually we would have the two behave the same so it would not even be a problem for the future. >> Another topic would be ObsoleteFiles.inc (or >> OptionalObsoleteFiles.inc) needs to be updated for this as well. > I don't think they should be updated. From now on, xzgrep and such > are always created and they always point to BSD grep, which can be > /usr/bin/grep or /usr/bin/bsdgrep depending on WITH_BSD_GREP. But > they always exist and point to one or another. I cannot think of > any case when they should be removed. Ah ok, I thought there was an option to disable building of bsdgrep but I were wrong here. Sorry for the noise. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJO1Cg9AAoJEATO+BI/yjfB+yAIAK7v7GJNaBIa25TFnbw4siRb c7LZ0VOp2W3i+QlmzhoWDFkW4SLedol93dKiD5ymDAhTrgaN/KS1ul2vb3kYrrr7 ZblinAfb1/NSWEtmQaUqZffExT1wBpGhLPRKm979Mn6BMHgaV5f+PqKw36uTwuqA 9O8AFZnEsplkf5FI71758yXugS48DzJnaAD/7/jC7v/l2GNHs7l+HMTBOS50/I/2 mLX98uerCYvIZ9U51Le4J9WI62oN9HcmVqTG0brUvVYCyEtL7Cjf8MrYE3b1m16l q5YU1uyTMQPTpQhIlRGUe80hcNN0kROpjR5hez0i/2gKXp3BSKVPyB0peTC34n0= =6v/S -----END PGP SIGNATURE-----