From owner-cvs-all@FreeBSD.ORG  Sun Jan 27 10:51:18 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0258F16A420;
	Sun, 27 Jan 2008 10:51:18 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id BE84513C4CE;
	Sun, 27 Jan 2008 10:51:17 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 326BD46BFD;
	Sun, 27 Jan 2008 05:51:17 -0500 (EST)
Date: Sun, 27 Jan 2008 10:51:17 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Yar Tikhiy <yar@FreeBSD.org>
In-Reply-To: <20080127063533.GA62684@freefall.freebsd.org>
Message-ID: <20080127104856.P30050@fledge.watson.org>
References: <200801270119.m0R1JlKn096256@repoman.freebsd.org>
	<20080127063533.GA62684@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, John Birrell <jb@FreeBSD.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/setfmac setfmac.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2008 10:51:18 -0000


On Sun, 27 Jan 2008, Yar Tikhiy wrote:

> The format strings in question might just have a bug in them. My guess is 
> that the author of the format strings feared that fts_path might not be 
> NUL-terminated, so he explicitly specified variable precision of 
> fts_pathlen; but he forgot to left-justify the field as well.
>
> In fact, fts_path in a fresh FTSENT just returned by fts_read() is always 
> NUL-terminated.  (See fts(3).)  Tricks with fts_pathlen are necessary only 
> if referring to old, saved FTSENTs, but this is dangerous and unportable 
> anyway.  setfmac seems to refer to fresh FTSENTs only, so the format can be 
> changed safely from "%.*s" to just "%s".  It will eliminate the fts_pathlen 
> arguments to the printf-like functions completely.
>
> It was Robert Watson who committed the lines to setfmac.c, according to cvs 
> annotate, so I added him to Cc:.
>
> Robert, do you think it's OK to simplify the format strings by changing 
> "%.*s" to "%s" along with removing the fts_pathlen arguments? E.g.:

I think Brian Feldman may have originally submitted this part of the code 
code, and likely it was a concern about nul-termination.  I'm fine with the 
change, especially if the concern about nul-termination was unfounded :-).

Robert N M Watson
Computer Laboratory
University of Cambridge

>
>                case FTS_NS:
> -                       err(1, "traversing %.*s", ftsent->fts_pathlen,
> -                           ftsent->fts_path);
> +                       err(1, "traversing %s", ftsent->fts_path);
>                default:
>
> Thanks!
>
> Yar
>