From owner-p4-projects Wed May 29 7:40:25 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 388D337B401; Wed, 29 May 2002 07:40:09 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id 119D837B400 for ; Wed, 29 May 2002 07:40:07 -0700 (PDT) Received: (qmail 9343 invoked from network); 29 May 2002 14:40:05 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 29 May 2002 14:40:05 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4TEeJF27951; Wed, 29 May 2002 10:40:19 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020529103428.A68375@unixdaemons.com> Date: Wed, 29 May 2002 10:39:45 -0400 (EDT) From: John Baldwin To: Bosko Milekic Subject: Re: PERFORCE change 12066 for review Cc: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 29-May-2002 Bosko Milekic wrote: > > This is a great change. How soon will we see it in CVS? When it's tested. I really try to avoid committing untested stuff, but sometimes it is tempting for simple stuff like this. > On Wed, May 29, 2002 at 07:29:42AM -0700, John Baldwin wrote: >> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12066 >> >> Change 12066 by jhb@jhb_laptop on 2002/05/29 07:28:41 >> >> Spin w/o holding sched_lock until mtx_lock changes when we are >> adaptively spinning. >> >> Affected files ... >> >> ... //depot/projects/smpng/sys/kern/kern_mutex.c#34 edit >> >> Differences ... >> >> ==== //depot/projects/smpng/sys/kern/kern_mutex.c#34 (text+ko) ==== >> >> @@ -533,9 +533,11 @@ >> if (m != &Giant && owner->td_kse != NULL && >> owner->td_kse->ke_oncpu != NOCPU) { >> mtx_unlock_spin(&sched_lock); >> + while (mtx_owner(m) == owner) { >> #ifdef __i386__ >> - cpu_pause(); >> + cpu_pause(); >> #endif >> + } >> continue; >> } >> #endif /* SMP && ADAPTIVE_MUTEXES */ >> > > -- > Bosko Milekic > bmilekic@unixdaemons.com > bmilekic@FreeBSD.org > -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message