Date: Wed, 29 May 2002 10:39:45 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bosko Milekic <bmilekic@unixdaemons.com> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 12066 for review Message-ID: <XFMail.20020529103945.jhb@FreeBSD.org> In-Reply-To: <20020529103428.A68375@unixdaemons.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29-May-2002 Bosko Milekic wrote: > > This is a great change. How soon will we see it in CVS? When it's tested. I really try to avoid committing untested stuff, but sometimes it is tempting for simple stuff like this. > On Wed, May 29, 2002 at 07:29:42AM -0700, John Baldwin wrote: >> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12066 >> >> Change 12066 by jhb@jhb_laptop on 2002/05/29 07:28:41 >> >> Spin w/o holding sched_lock until mtx_lock changes when we are >> adaptively spinning. >> >> Affected files ... >> >> ... //depot/projects/smpng/sys/kern/kern_mutex.c#34 edit >> >> Differences ... >> >> ==== //depot/projects/smpng/sys/kern/kern_mutex.c#34 (text+ko) ==== >> >> @@ -533,9 +533,11 @@ >> if (m != &Giant && owner->td_kse != NULL && >> owner->td_kse->ke_oncpu != NOCPU) { >> mtx_unlock_spin(&sched_lock); >> + while (mtx_owner(m) == owner) { >> #ifdef __i386__ >> - cpu_pause(); >> + cpu_pause(); >> #endif >> + } >> continue; >> } >> #endif /* SMP && ADAPTIVE_MUTEXES */ >> > > -- > Bosko Milekic > bmilekic@unixdaemons.com > bmilekic@FreeBSD.org > -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020529103945.jhb>