From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 27 18:50:22 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1008316A420 for ; Mon, 27 Feb 2006 18:50:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F59243D8F for ; Mon, 27 Feb 2006 18:50:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1RIo695088712 for ; Mon, 27 Feb 2006 18:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1RIo6NK088711; Mon, 27 Feb 2006 18:50:06 GMT (envelope-from gnats) Resent-Date: Mon, 27 Feb 2006 18:50:06 GMT Resent-Message-Id: <200602271850.k1RIo6NK088711@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Onno Molenkamp Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A005B16A420 for ; Mon, 27 Feb 2006 18:47:56 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B33543D78 for ; Mon, 27 Feb 2006 18:47:51 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k1RIlpp3013342 for ; Mon, 27 Feb 2006 18:47:51 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k1RIlotu013341; Mon, 27 Feb 2006 18:47:50 GMT (envelope-from nobody) Message-Id: <200602271847.k1RIlotu013341@www.freebsd.org> Date: Mon, 27 Feb 2006 18:47:50 GMT From: Onno Molenkamp To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/93909: STP doesn't transmit its own bridge id X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2006 18:50:22 -0000 >Number: 93909 >Category: kern >Synopsis: STP doesn't transmit its own bridge id >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 27 18:50:06 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Onno Molenkamp >Release: 6.0-STABLE >Organization: >Environment: FreeBSD duiveltje 6.0-STABLE FreeBSD 6.0-STABLE #0: Mon Jan 16 13:54:19 CET 2006 root@duiveltje:/usr/obj/usr/src/sys/DUIVELTJE i386 >Description: The code in net/bridgestp.c that builds up a packet to be transmitted over the network incorrectly puts the root id in the bridge id field. I noticed this behaviour in 6.0-STABLE version from a while ago, but the bug still exists in current CVS. >How-To-Repeat: Use an if_bridge bridge with STP. >Fix: --- net/bridgestp.c Tue Jan 10 00:53:40 2006 +++ net/bridgestp.c.new Mon Feb 27 19:42:24 2006 @@ -269,13 +269,13 @@ bpdu.cbu_rootpathcost = htonl(cu->cu_root_path_cost); - bpdu.cbu_bridgepri = htons(cu->cu_rootid >> 48); - bpdu.cbu_bridgeaddr[0] = cu->cu_rootid >> 40; - bpdu.cbu_bridgeaddr[1] = cu->cu_rootid >> 32; - bpdu.cbu_bridgeaddr[2] = cu->cu_rootid >> 24; - bpdu.cbu_bridgeaddr[3] = cu->cu_rootid >> 16; - bpdu.cbu_bridgeaddr[4] = cu->cu_rootid >> 8; - bpdu.cbu_bridgeaddr[5] = cu->cu_rootid >> 0; + bpdu.cbu_bridgepri = htons(cu->cu_bridge_id >> 48); + bpdu.cbu_bridgeaddr[0] = cu->cu_bridge_id >> 40; + bpdu.cbu_bridgeaddr[1] = cu->cu_bridge_id >> 32; + bpdu.cbu_bridgeaddr[2] = cu->cu_bridge_id >> 24; + bpdu.cbu_bridgeaddr[3] = cu->cu_bridge_id >> 16; + bpdu.cbu_bridgeaddr[4] = cu->cu_bridge_id >> 8; + bpdu.cbu_bridgeaddr[5] = cu->cu_bridge_id >> 0; bpdu.cbu_portid = htons(cu->cu_port_id); bpdu.cbu_messageage = htons(cu->cu_message_age); >Release-Note: >Audit-Trail: >Unformatted: