From owner-svn-src-all@FreeBSD.ORG  Sun Aug 14 17:06:21 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id B286F106566B; Sun, 14 Aug 2011 17:06:21 +0000 (UTC)
Date: Sun, 14 Aug 2011 17:06:21 +0000
From: Alexander Best <arundel@freebsd.org>
To: Niclas Zeising <niclas.zeising@gmail.com>
Message-ID: <20110814170621.GA4189@freebsd.org>
References: <201108131603.p7DG3e80023093@svn.freebsd.org>
	<4E47EF64.2070405@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E47EF64.2070405@gmail.com>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Robert Watson <rwatson@FreeBSD.org>
Subject: Re: svn commit: r224842 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Aug 2011 17:06:21 -0000

On Sun Aug 14 11, Niclas Zeising wrote:
> On 2011-08-13 18:03, Robert Watson wrote:
> > Author: rwatson
> > Date: Sat Aug 13 16:03:40 2011
> > New Revision: 224842
> > URL: http://svn.freebsd.org/changeset/base/224842
> > 
> > Log:
> >   When falloc() was broken into separate falloc_noinstall() and finstall(),
> >   a bug was introduced in kern_openat() such that the error from the vnode
> >   open operation was overwritten before it was passed as an argument to
> >   dupfdopen().  This broke operations on /dev/{stdin,stdout,stderr}.  Fix
> >   by preserving the original error number across finstall() so that it is
> >   still available.
> >   
> >   Approved by:	re (kib)
> >   Reported by:	cognet
> > 
> > Modified:
> >   head/sys/kern/vfs_syscalls.c
> > 
> 
> It might be worth mentioning this in UPDATING or similar, since a kernel
> built with clang (I haven't tried gcc) during this window will make it
> impossible to do a buildworld without first rebuilding the kernel with
> this fix. It also seems to break at least portsnap, and possibly other
> tools as well.

+1. please also mention the KPI change to fget()! so many people have had
issues, where 3rd party drivers - mostly the nvidia binary driver - got broken.

cheers.
alex

> 
> Regards!
> -- 
> Niclas Zeising