From owner-p4-projects@FreeBSD.ORG  Fri Jan 19 16:58:16 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4F70516A406; Fri, 19 Jan 2007 16:58:16 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1F9E316A402
	for <perforce@freebsd.org>; Fri, 19 Jan 2007 16:58:16 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190])
	by mx1.freebsd.org (Postfix) with ESMTP id AD96313C46A
	for <perforce@freebsd.org>; Fri, 19 Jan 2007 16:58:15 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: by nf-out-0910.google.com with SMTP id k27so521995nfc
	for <perforce@freebsd.org>; Fri, 19 Jan 2007 08:58:14 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=gNgqirHGt0hvdVI5ffBv1FKqQ3keRM+QYIj6YpWtrtRbtgd45HbqwBwiRFTry0GrrDRlqkai+ivmNZX7vQ0P6NmcWqqxtQP5/Td6Ip6xdr/2VE/q82L6aJSH34gyMpwU72xgPdrEiX7PykMRSbfxYD/udIo46ASZHudsTOtAUMw=
Received: by 10.49.8.16 with SMTP id l16mr2348807nfi.1169225893639;
	Fri, 19 Jan 2007 08:58:13 -0800 (PST)
Received: by 10.48.238.14 with HTTP; Fri, 19 Jan 2007 08:58:13 -0800 (PST)
Message-ID: <3bbf2fe10701190858v4fbdf5ct5fd39c6e16f2a10d@mail.gmail.com>
Date: Fri, 19 Jan 2007 17:58:13 +0100
From: "Attilio Rao" <attilio@freebsd.org>
Sender: asmrookie@gmail.com
To: "Hans Petter Selasky" <hselasky@freebsd.org>
In-Reply-To: <200701191656.l0JGuPu7025321@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200701191656.l0JGuPu7025321@repoman.freebsd.org>
X-Google-Sender-Auth: 31ac43d4c607d25c
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 113164 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jan 2007 16:58:16 -0000

2007/1/19, Hans Petter Selasky <hselasky@freebsd.org>:
> http://perforce.freebsd.org/chv.cgi?CH=113164
>
> Change 113164 by hselasky@hselasky_mini_itx on 2007/01/19 16:56:15
>
>         The sound mutex needs to allow recursion, else the
>         new "uaudio" will not work.
>
> Affected files ...
>
> .. //depot/projects/usb/src/sys/dev/sound/pcm/sound.c#3 edit
>
> Differences ...
>
> ==== //depot/projects/usb/src/sys/dev/sound/pcm/sound.c#3 (text+ko) ====
>
> @@ -78,7 +78,7 @@
>         m = malloc(sizeof(*m), M_DEVBUF, M_WAITOK | M_ZERO);
>         if (m == NULL)
>                 return NULL;
> -       mtx_init(m, desc, type, MTX_DEF);
> +       mtx_init(m, desc, type, MTX_DEF|MTX_RECURSE);
>         return m;
>  #else
>         return (void *)0xcafebabe;
>

Recursed mutexes very often are symptomatic of some some bug...
it is the case? why the mutex is recursed?

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein