From owner-cvs-sys Fri May 3 02:39:34 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id CAA15748 for cvs-sys-outgoing; Fri, 3 May 1996 02:39:34 -0700 (PDT) Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id CAA15743 Fri, 3 May 1996 02:39:24 -0700 (PDT) Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0uFHKQ-0003wfC; Fri, 3 May 96 02:39 PDT Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.7.5/8.6.12) with SMTP id JAA01614; Fri, 3 May 1996 09:39:10 GMT X-Authentication-Warning: critter.tfs.com: Host localhost [127.0.0.1] didn't use HELO protocol To: davidg@Root.COM cc: Poul-Henning Kamp , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/scsi sd.c In-reply-to: Your message of "Thu, 02 May 1996 16:22:08 MST." <199605022322.QAA00916@Root.COM> Date: Fri, 03 May 1996 09:39:08 +0000 Message-ID: <1612.831116348@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > >phk 96/05/02 15:20:54 > > > > Modified: sys/scsi sd.c > > Log: > > Don't fiddle page tables by hand, use pmap_enter. > > (copied from wd.c) > > > > Revision Changes Path > > 1.89 +4 -4 src/sys/scsi/sd.c > > Actually, you probably should have changed it the other way - made wd.c > more like sd.c. Using pmap_enter() at this point isn't very wise. Well, then we want a function in pmap.c for exactly this purpose, I do not see this as belonging in, of all things, sys/scsi/sd.c ! -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.