From owner-cvs-src@FreeBSD.ORG Fri Sep 30 14:17:38 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A4D616A41F; Fri, 30 Sep 2005 14:17:38 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87B7943D49; Fri, 30 Sep 2005 14:17:36 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Fri, 30 Sep 2005 10:33:07 -0400 From: John Baldwin To: Nate Lawson Date: Fri, 30 Sep 2005 10:14:19 -0400 User-Agent: KMail/1.8 References: <20050928192056.B7E6D16A42B@hub.freebsd.org> <200509291406.19775.jhb@FreeBSD.org> <433C441A.8050508@root.org> In-Reply-To: <433C441A.8050508@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509301014.21572.jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2005 14:17:38 -0000 On Thursday 29 September 2005 03:44 pm, Nate Lawson wrote: > John Baldwin wrote: > > On Thursday 29 September 2005 01:49 pm, Nate Lawson wrote: > >>John Baldwin wrote: > >>>On Wednesday 28 September 2005 04:36 pm, Nate Lawson wrote: > >>>>I've heard disabling apic helps T42s, otherwise they get a hard hang. > >>>>It's difficult to print the driver progress while suspending because > >>>> the function call stack is recursive, not iterative. For example, > >>>> root_suspend -> pci_suspend -> fxp_suspend -> mii_suspend (if that > >>>> exists). You'd have to add a printf in every driver and bus. A > >>>> better way might be to add printf or KTR to bus_generic_suspend() to > >>>> print the device name before calling its method. > >>>> > >>>>BTW, I'm working on committing a patch that adds KTR to acpi so we can > >>>>track down issues like this although the device suspending stuff should > >>>>be done separately as listed above. > >>> > >>>BTW, the issue with APIC on some systems is that when we use the APIC, > >>>the current code doesn't end up doing suspend/resume for the ATPIC and > >>> so it ends up in some random state. > >> > >>Ah, is a fix for that upcoming? :) > > > > It's in my head. I think I need to rework the suspend/resume support in > > the x86 interrupt code to instead of doing all the interrupt sources, > > having the atpic and apic code register pic devices in a separate list > > that gets iterated on suspend and resume. > > I think that makes sense since they have different programming methods. > Does it make sense to separate them into different newbus devices as > well, so you get proper ordering? Getting interrupt controllers into new-bus is a far-off goal I think. It needs all that multipass stuff in place first. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org