From owner-svn-src-head@FreeBSD.ORG Wed Oct 22 09:58:42 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9EE58A27 for ; Wed, 22 Oct 2014 09:58:42 +0000 (UTC) Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A4D7796 for ; Wed, 22 Oct 2014 09:58:42 +0000 (UTC) Received: by mail-qg0-f43.google.com with SMTP id j107so2242350qga.16 for ; Wed, 22 Oct 2014 02:58:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=X8LxzuTyJZMOHbM0feoqjQVZd3eBQRKy7anwcIDsmwk=; b=ak0I4gJkp8PR9TRNxKmmsjACrsGY4LbX7XODudxOItC/RxkDKXux4LylraGjIQdrmk p+Upq2LFHTAh589ISUc6oTGbgqIxG+IxE1h+6wqdQpesjPX6+aNqZeIMV5TwlFk083aK dc6/hmNpK+4jpz/fP+NW46cbNrM8wBR5mlS1Vojj+Swo3QjymZxvgHIAwO5lNMpJB4K9 7WPhf3pgWcZlR5v5UnS9V/LZWxNTacFylB60G9loNkoWqxRbS68zFENc0fBx7Kc0d9BB SVIVOyLtGES8JvIqDnpz5v0jYiLj3txwhQvdSZ54t4b5aR7ZQUhWAAlv/HOnHYdN1OD1 LLHw== X-Gm-Message-State: ALoCoQlpNkTb/tE9ovZI/JvaVzOXFaM6Kc9FhkiJJ67sLaycASjx0y3urR8+91R0gWZSiCvUIOzf X-Received: by 10.224.61.7 with SMTP id r7mr54975239qah.9.1413971921057; Wed, 22 Oct 2014 02:58:41 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.75.134 with HTTP; Wed, 22 Oct 2014 02:58:20 -0700 (PDT) X-Originating-IP: [2620:0:1040:404:e8f9:fd1a:c493:d286] In-Reply-To: <201410211756.s9LHu6Q9098073@svn.freebsd.org> References: <201410211756.s9LHu6Q9098073@svn.freebsd.org> From: Julio Merino Date: Wed, 22 Oct 2014 10:58:20 +0100 X-Google-Sender-Auth: Z4gI8vO2UrPvJvPbDf5C6eIrruA Message-ID: Subject: Re: svn commit: r273389 - head/contrib/netbsd-tests/lib/libc/gen To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 09:58:42 -0000 On Tue, Oct 21, 2014 at 6:56 PM, Garrett Cooper wrote: > Modified: head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c > ============================================================================== > --- head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c Tue Oct 21 17:17:40 2014 (r273388) > +++ head/contrib/netbsd-tests/lib/libc/gen/t_siginfo.c Tue Oct 21 17:56:06 2014 (r273389) > @@ -29,7 +29,9 @@ > #include > #include > > +#if defined(__NetBSD__) Every time I see this (and checks for __FreeBSD__ as well), I can't stop wondering... "why bother?" This codebase lives in the FreeBSD source tree so it should be able to assume it is being built on FreeBSD. The only thing these ifdefs achieve is bloat, because there is no way their code paths will ever be executed (and thus it's guaranteed that they will rot over time). The differences between NetBSD and FreeBSD can easily be checked by diffing the vendor branch with the contrib tree. (Plus #ifdefs based on __*BSD__ macros are usually wrong because they don't account for OS release differences and thus they will certainly also break over time.)