From owner-cvs-all Thu Dec 7 10:50:47 2000 From owner-cvs-all@FreeBSD.ORG Thu Dec 7 10:50:42 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id BFBE537B400; Thu, 7 Dec 2000 10:50:42 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eB7IoA723556; Thu, 7 Dec 2000 10:50:10 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eB7IoD164731; Thu, 7 Dec 2000 10:50:13 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200012071836.eB7Ia0g20591@curve.dellroad.org> Date: Thu, 07 Dec 2000 10:50:13 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Archie Cobbs Subject: Re: cvs commit: src/sys/dev/ichsmb ichsmb.c ichsmb_var.h Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Sender: jhb@foo.osd.bsdi.com Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 07-Dec-00 Archie Cobbs wrote: > John Baldwin writes: >> > Mind if I ask why? Sorry if I'm missing something obvious. >> >> I'm just pushing the panic button a little. We aren't really yet ready as >> it >> were for locking drivers yet is all, so I just want to have a look-see over >> the >> first few that go in to make sure they will server as good examples to >> everyone >> else. > > Sounds prudent. So.. how'd I do?? :-) Looks ok at first glance. :) Was splhigh() protecting anything other than the ichsmb softc? Also, which SMBus methods are you referring to in this comment? + * + * This driver assumes that the generic SMBus code will ensure that + * at most one process at a time calls into the SMBus methods below. > -Archie -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message