From owner-svn-src-head@FreeBSD.ORG  Wed Jun 10 15:44:56 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2B5BB360;
 Wed, 10 Jun 2015 15:44:56 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 021E11AB0;
 Wed, 10 Jun 2015 15:44:54 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t5AFijF3042127
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 10 Jun 2015 18:44:45 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t5AFijQB042126;
 Wed, 10 Jun 2015 18:44:45 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 10 Jun 2015 18:44:45 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mateusz Guzik <mjg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r284211 - in head/sys: kern sys
Message-ID: <20150610154445.GJ73119@FreeBSD.org>
References: <201506100934.t5A9YpoN093925@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201506100934.t5A9YpoN093925@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 15:44:56 -0000

On Wed, Jun 10, 2015 at 09:34:51AM +0000, Mateusz Guzik wrote:
M> Author: mjg
M> Date: Wed Jun 10 09:34:50 2015
M> New Revision: 284211
M> URL: https://svnweb.freebsd.org/changeset/base/284211
M> 
M> Log:
M>   fd: use atomics to manage fd_refcnt and fd_holcnt
M>   
M>   This gets rid of fdesc_mtx.
..
M> Modified: head/sys/sys/filedesc.h
M> ==============================================================================
M> --- head/sys/sys/filedesc.h	Wed Jun 10 05:39:48 2015	(r284210)
M> +++ head/sys/sys/filedesc.h	Wed Jun 10 09:34:50 2015	(r284211)
M> @@ -83,8 +83,8 @@ struct filedesc {
M>  	int	fd_lastfile;		/* high-water mark of fd_ofiles */
M>  	int	fd_freefile;		/* approx. next free file */
M>  	u_short	fd_cmask;		/* mask for file creation */
M> -	u_short	fd_refcnt;		/* thread reference count */
M> -	u_short	fd_holdcnt;		/* hold count on structure + mutex */
M> +	int	fd_refcnt;		/* thread reference count */
M> +	int	fd_holdcnt;		/* hold count on structure + mutex */
M>  	struct	sx fd_sx;		/* protects members of this struct */
M>  	struct	kqlist fd_kqlist;	/* list of kqueues on this filedesc */
M>  	int	fd_holdleaderscount;	/* block fdfree() for shared close() */

Shouldn't they be volatile u_int?

-- 
Totus tuus, Glebius.