Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Feb 2020 21:18:16 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r357540 - head/contrib/elftoolchain/readelf
Message-ID:  <202002042118.014LIGeb019294@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue Feb  4 21:18:16 2020
New Revision: 357540
URL: https://svnweb.freebsd.org/changeset/base/357540

Log:
  readelf: Fix a double close of the input file.
  
  The caller of dump_object() is responsible for opening the file, let it
  be responsible for closing too.
  
  CID:		1411588
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/contrib/elftoolchain/readelf/readelf.c

Modified: head/contrib/elftoolchain/readelf/readelf.c
==============================================================================
--- head/contrib/elftoolchain/readelf/readelf.c	Tue Feb  4 21:17:59 2020	(r357539)
+++ head/contrib/elftoolchain/readelf/readelf.c	Tue Feb  4 21:18:16 2020	(r357540)
@@ -7247,7 +7247,6 @@ dump_object(struct readelf *re, int fd)
 
 done:
 	elf_end(re->elf);
-	close(fd);
 }
 
 static void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002042118.014LIGeb019294>