From owner-svn-src-head@FreeBSD.ORG Sat Feb 13 11:47:05 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D9B3106566B; Sat, 13 Feb 2010 11:47:05 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EEE3D8FC15; Sat, 13 Feb 2010 11:47:04 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o1DBl4mn020044; Sat, 13 Feb 2010 11:47:04 GMT (envelope-from avg@svn.freebsd.org) Received: (from avg@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o1DBl4hK020042; Sat, 13 Feb 2010 11:47:04 GMT (envelope-from avg@svn.freebsd.org) Message-Id: <201002131147.o1DBl4hK020042@svn.freebsd.org> From: Andriy Gapon Date: Sat, 13 Feb 2010 11:47:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203823 - head/gnu/usr.bin/gdb/kgdb X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2010 11:47:05 -0000 Author: avg Date: Sat Feb 13 11:47:04 2010 New Revision: 203823 URL: http://svn.freebsd.org/changeset/base/203823 Log: kgdb: initialize n_type field of nlist entry for kvm_nlist call kvm_nlist skips lookup for entries that have n_type != N_UNDF. N_UNDF happens to be zero, so n_type typically has a correct value by accident, but not always. Note: jhb has a patch that replaces kvm_nlist use with direct gdb parsing. MFC after: 5 days X-MFC-Note: unless jhb commits kvm_nlist => kgdb_parse change Modified: head/gnu/usr.bin/gdb/kgdb/kthr.c Modified: head/gnu/usr.bin/gdb/kgdb/kthr.c ============================================================================== --- head/gnu/usr.bin/gdb/kgdb/kthr.c Sat Feb 13 11:34:25 2010 (r203822) +++ head/gnu/usr.bin/gdb/kgdb/kthr.c Sat Feb 13 11:47:04 2010 (r203823) @@ -58,6 +58,7 @@ kgdb_lookup(const char *sym) { struct nlist nl[2]; + nl[0].n_type = N_UNDF; nl[0].n_name = (char *)(uintptr_t)sym; nl[1].n_name = NULL; if (kvm_nlist(kvm, nl) != 0)