From owner-freebsd-acpi@FreeBSD.ORG  Tue Nov  2 15:29:59 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C3A5D106564A;
	Tue,  2 Nov 2010 15:29:59 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id A6B608FC16;
	Tue,  2 Nov 2010 15:29:58 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA14943;
	Tue, 02 Nov 2010 17:29:49 +0200 (EET) (envelope-from avg@freebsd.org)
Message-ID: <4CD02E6D.1070106@freebsd.org>
Date: Tue, 02 Nov 2010 17:29:49 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.11) Gecko/20101021 Lightning/1.0b2 Thunderbird/3.1.5
MIME-Version: 1.0
To: Hans Petter Selasky <hselasky@c2i.net>
References: <201010121209.06397.hselasky@c2i.net>	
	<1288278300.2459.19.camel@localhost>
	<1288279472.2459.22.camel@localhost>	
	<201010281810.23668.hselasky@c2i.net>
	<1288312476.13315.15.camel@minggr.sh.intel.com>
	<4CCA594C.7050806@icyb.net.ua> <4CCA5A3B.9000101@icyb.net.ua>
	<4CCA60C9.7040600@icyb.net.ua>
In-Reply-To: <4CCA60C9.7040600@icyb.net.ua>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-acpi@freebsd.org, Lin Ming <ming.m.lin@intel.com>, "Moore,
	Robert" <robert.moore@intel.com>
Subject: Re: MacBookPro 5,1
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2010 15:29:59 -0000

on 29/10/2010 08:51 Andriy Gapon said the following:
> I guess that a general problem here is that it is incorrect to merely use
> memcpy/bcopy to create a copy of a resource if the resource has
> ACPI_RESOURCE_SOURCE field in it.

Hans,

could you please test the following patch?

diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c
index dcf101d..e842635 100644
--- a/sys/dev/acpica/acpi_pci_link.c
+++ b/sys/dev/acpica/acpi_pci_link.c
@@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs
 				    link->l_irq;
 			else
 				resptr->Data.ExtendedIrq.Interrupts[0] = 0;
+			memset(&resptr->Data.ExtendedIrq.ResourceSource, 0,
+			    sizeof(ACPI_RESOURCE_SOURCE));
 			link++;
 			i++;
 			break;


-- 
Andriy Gapon