From owner-svn-src-all@freebsd.org Mon Jul 6 20:11:40 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB0A79953F8 for ; Mon, 6 Jul 2015 20:11:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) by mx1.freebsd.org (Postfix) with SMTP id 8F5F4144D for ; Mon, 6 Jul 2015 20:11:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 6 Jul 2015 20:12:10 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t66KBW8G032787; Mon, 6 Jul 2015 14:11:32 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1436213492.1334.64.camel@freebsd.org> Subject: Re: svn commit: r285217 - head/usr.sbin/bhyve From: Ian Lepore To: Neel Natu Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 06 Jul 2015 14:11:32 -0600 In-Reply-To: <201507061933.t66JXTtJ050058@repo.freebsd.org> References: <201507061933.t66JXTtJ050058@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2015 20:11:40 -0000 On Mon, 2015-07-06 at 19:33 +0000, Neel Natu wrote: > Author: neel > Date: Mon Jul 6 19:33:29 2015 > New Revision: 285217 > URL: https://svnweb.freebsd.org/changeset/base/285217 > > Log: > Always assert DCD and DSR in bhyve's uart emulation. > > The /etc/ttys entry for a serial console in FreeBSD/x86 is as follows: > ttyu0 "/usr/libexec/getty 3wire" vt100 onifconsole secure > > The initial terminal type passed to getty(8) is "3wire" which sets the > CLOCAL flag. However reset(1) clears this flag and any programs that try > to open the terminal will hang waiting for DCD to be asserted. > > Fix this by always asserting DCD and DSR in the emulated uart. > > The following discussion on virtualization@ has more details: > https://lists.freebsd.org/pipermail/freebsd-virtualization/2015-June/003666.html > > Reported by: jmg > Discussed with: grehan This seems like a wrong fix. A real 3-wire serial console doesn't have DCD and DSR wired on. Why isn't the right fix here having the user with this problem to do "stty -f /dev/ttyu0.lock clocal", maybe in rc.local? Hmmm, or maybe it would be right for getty to do the equivelent when it sees a 3wire type? -- Ian