Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Jul 2016 00:22:14 +0000 (UTC)
From:      Glen Barber <gjb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r302410 - in stable/11: . contrib/jemalloc/include/jemalloc etc/defaults sys/amd64/conf sys/i386/conf sys/powerpc/conf sys/sparc64/conf
Message-ID:  <201607080022.u680MEb1003687@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gjb
Date: Fri Jul  8 00:22:14 2016
New Revision: 302410
URL: https://svnweb.freebsd.org/changeset/base/302410

Log:
  - Remove debugging from GENERIC* kernel configurations
  - Enable MALLOC_PRODUCTION
  - Default dumpdev=NO
  - Remove UPDATING entry regarding debugging features
  
  Approved by:	re (implicit)
  Sponsored by:	The FreeBSD Foundation

Modified:
  stable/11/UPDATING
  stable/11/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h
  stable/11/etc/defaults/rc.conf
  stable/11/sys/amd64/conf/GENERIC
  stable/11/sys/i386/conf/GENERIC
  stable/11/sys/powerpc/conf/GENERIC
  stable/11/sys/sparc64/conf/GENERIC

Modified: stable/11/UPDATING
==============================================================================
--- stable/11/UPDATING	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/UPDATING	Fri Jul  8 00:22:14 2016	(r302410)
@@ -16,21 +16,6 @@ from older versions of FreeBSD, try WITH
 the tip of head, and then rebuild without this option. The bootstrap process
 from older version of current across the gcc/clang cutover is a bit fragile.
 
-NOTE TO PEOPLE WHO THINK THAT FreeBSD 11.x IS SLOW:
-	FreeBSD 11.x has many debugging features turned on, in both the kernel
-	and userland.  These features attempt to detect incorrect use of
-	system primitives, and encourage loud failure through extra sanity
-	checking and fail stop semantics.  They also substantially impact
-	system performance.  If you want to do performance measurement,
-	benchmarking, and optimization, you'll want to turn them off.  This
-	includes various WITNESS- related kernel options, INVARIANTS, malloc
-	debugging flags in userland, and various verbose features in the
-	kernel.  Many developers choose to disable these features on build
-	machines to maximize performance.  (To completely disable malloc
-	debugging, define MALLOC_PRODUCTION in /etc/make.conf, or to merely
-	disable the most expensive debugging functionality run
-	"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
-
 20160622:
 	The libc stub for the pipe(2) system call has been replaced with
 	a wrapper which calls the pipe2(2) system call and the pipe(2) is now

Modified: stable/11/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h
==============================================================================
--- stable/11/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h	Fri Jul  8 00:22:14 2016	(r302410)
@@ -5,6 +5,9 @@
 #undef JEMALLOC_OVERRIDE_VALLOC
 
 #ifndef MALLOC_PRODUCTION
+#define	MALLOC_PRODUCTION
+#endif
+#ifndef MALLOC_PRODUCTION
 #define	JEMALLOC_DEBUG
 #endif
 

Modified: stable/11/etc/defaults/rc.conf
==============================================================================
--- stable/11/etc/defaults/rc.conf	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/etc/defaults/rc.conf	Fri Jul  8 00:22:14 2016	(r302410)
@@ -609,7 +609,7 @@ lpd_flags=""		# Flags to lpd (if enabled
 nscd_enable="NO"	# Run the nsswitch caching daemon.
 chkprintcap_enable="NO"	# Run chkprintcap(8) before running lpd.
 chkprintcap_flags="-d"	# Create missing directories by default.
-dumpdev="AUTO"		# Device to crashdump to (device name, AUTO, or NO).
+dumpdev="NO"		# Device to crashdump to (device name, AUTO, or NO).
 dumpdir="/var/crash"	# Directory where crash dumps are to be stored
 savecore_enable="YES"	# Extract core from dump devices if any
 savecore_flags="-m 10"	# Used if dumpdev is enabled above, and present.

Modified: stable/11/sys/amd64/conf/GENERIC
==============================================================================
--- stable/11/sys/amd64/conf/GENERIC	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/sys/amd64/conf/GENERIC	Fri Jul  8 00:22:14 2016	(r302410)
@@ -81,15 +81,6 @@ options 	RCTL			# Resource limits
 # Debugging support.  Always need this:
 options 	KDB			# Enable kernel debugger support.
 options 	KDB_TRACE		# Print a stack trace for a panic.
-# For full debugger support use (turn off in stable branch):
-options 	DDB			# Support DDB.
-options 	GDB			# Support remote GDB.
-options 	DEADLKRES		# Enable the deadlock resolver
-options 	INVARIANTS		# Enable calls of extra sanity checking
-options 	INVARIANT_SUPPORT	# Extra sanity checks of internal structures, required by INVARIANTS
-options 	WITNESS			# Enable checks to detect deadlocks and cycles
-options 	WITNESS_SKIPSPIN	# Don't run witness on spinlocks for speed
-options 	MALLOC_DEBUG_MAXZONES=8	# Separate malloc(9) zones
 
 # Make an SMP-capable kernel by default
 options 	SMP			# Symmetric MultiProcessor Kernel

Modified: stable/11/sys/i386/conf/GENERIC
==============================================================================
--- stable/11/sys/i386/conf/GENERIC	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/sys/i386/conf/GENERIC	Fri Jul  8 00:22:14 2016	(r302410)
@@ -81,15 +81,6 @@ options 	RCTL			# Resource limits
 # Debugging support.  Always need this:
 options 	KDB			# Enable kernel debugger support.
 options 	KDB_TRACE		# Print a stack trace for a panic.
-# For full debugger support use (turn off in stable branch):
-options 	DDB			# Support DDB.
-options 	GDB			# Support remote GDB.
-options 	DEADLKRES		# Enable the deadlock resolver
-options 	INVARIANTS		# Enable calls of extra sanity checking
-options 	INVARIANT_SUPPORT	# Extra sanity checks of internal structures, required by INVARIANTS
-options 	WITNESS			# Enable checks to detect deadlocks and cycles
-options 	WITNESS_SKIPSPIN	# Don't run witness on spinlocks for speed
-options 	MALLOC_DEBUG_MAXZONES=8	# Separate malloc(9) zones
 
 # To make an SMP kernel, the next two lines are needed
 options 	SMP			# Symmetric MultiProcessor Kernel

Modified: stable/11/sys/powerpc/conf/GENERIC
==============================================================================
--- stable/11/sys/powerpc/conf/GENERIC	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/sys/powerpc/conf/GENERIC	Fri Jul  8 00:22:14 2016	(r302410)
@@ -85,14 +85,6 @@ options 	RCTL			# Resource limits
 # Debugging support.  Always need this:
 options 	KDB			# Enable kernel debugger support.
 options 	KDB_TRACE		# Print a stack trace for a panic.
-# For full debugger support use (turn off in stable branch):
-options 	DDB			#Support DDB
-#options 	DEADLKRES		#Enable the deadlock resolver
-options 	INVARIANTS		#Enable calls of extra sanity checking
-options 	INVARIANT_SUPPORT	#Extra sanity checks of internal structures, required by INVARIANTS
-options 	WITNESS			#Enable checks to detect deadlocks and cycles
-options 	WITNESS_SKIPSPIN	#Don't run witness on spinlocks for speed
-options 	MALLOC_DEBUG_MAXZONES=8	# Separate malloc(9) zones
 
 # Make an SMP-capable kernel by default
 options 	SMP			# Symmetric MultiProcessor Kernel

Modified: stable/11/sys/sparc64/conf/GENERIC
==============================================================================
--- stable/11/sys/sparc64/conf/GENERIC	Fri Jul  8 00:12:29 2016	(r302409)
+++ stable/11/sys/sparc64/conf/GENERIC	Fri Jul  8 00:22:14 2016	(r302410)
@@ -75,15 +75,6 @@ options 	RCTL			# Resource limits
 # Debugging support.  Always need this:
 options 	KDB			# Enable kernel debugger support.
 options 	KDB_TRACE		# Print a stack trace for a panic.
-# For full debugger support use (turn off in stable branch):
-options 	DDB			# Support DDB.
-options 	GDB			# Support remote GDB.
-options 	DEADLKRES		# Enable the deadlock resolver
-options 	INVARIANTS		# Enable calls of extra sanity checking
-options 	INVARIANT_SUPPORT	# Extra sanity checks of internal structures, required by INVARIANTS
-options 	WITNESS			# Enable checks to detect deadlocks and cycles
-options 	WITNESS_SKIPSPIN	# Don't run witness on spinlocks for speed
-options 	MALLOC_DEBUG_MAXZONES=8	# Separate malloc(9) zones
 
 # Make an SMP-capable kernel by default
 options 	SMP			# Symmetric MultiProcessor Kernel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607080022.u680MEb1003687>