From owner-svn-src-head@freebsd.org Thu Aug 13 22:57:57 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA1173AF10E; Thu, 13 Aug 2020 22:57:57 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BSMRS6NhXz3yP1; Thu, 13 Aug 2020 22:57:56 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 07DMvs9f045019; Thu, 13 Aug 2020 15:57:54 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 07DMvsde045018; Thu, 13 Aug 2020 15:57:54 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202008132257.07DMvsde045018@gndrsh.dnsmgr.net> Subject: Re: svn commit: r364221 - in head/lib/libbsnmp: . tests In-Reply-To: <202008132242.07DMgPn0045423@repo.freebsd.org> To: Bryan Drewery Date: Thu, 13 Aug 2020 15:57:54 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4BSMRS6NhXz3yP1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 22:57:57 -0000 > Author: bdrewery > Date: Thu Aug 13 22:42:24 2020 > New Revision: 364221 > URL: https://svnweb.freebsd.org/changeset/base/364221 > > Log: > Add test to for FreeBSD-SA-19:20.bsnmp > > Submitted by: Darrick Lew > Reviewed by: cem > Sponsored by: Dell EMC > Differential Revision: https://reviews.freebsd.org/D26037 > > Added: > head/lib/libbsnmp/tests/ > head/lib/libbsnmp/tests/Makefile (contents, props changed) > head/lib/libbsnmp/tests/bsnmpd_test.c (contents, props changed) > Modified: > head/lib/libbsnmp/Makefile > > Modified: head/lib/libbsnmp/Makefile > ============================================================================== > --- head/lib/libbsnmp/Makefile Thu Aug 13 22:06:27 2020 (r364220) > +++ head/lib/libbsnmp/Makefile Thu Aug 13 22:42:24 2020 (r364221) > @@ -1,5 +1,6 @@ > # $FreeBSD$ > > SUBDIR= libbsnmp > +SUBDIR.${MK_TESTS}+= tests > > .include > > Added: head/lib/libbsnmp/tests/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/lib/libbsnmp/tests/Makefile Thu Aug 13 22:42:24 2020 (r364221) > @@ -0,0 +1,11 @@ > +# $FreeBSD$ > + > +.include > + > +ATF_TESTS_C+= bsnmpd_test > + > +SRCS.bsmpd_test= bsnmpd_test.c > + > +LIBADD+= bsnmp > + > +.include > > Added: head/lib/libbsnmp/tests/bsnmpd_test.c > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/lib/libbsnmp/tests/bsnmpd_test.c Thu Aug 13 22:42:24 2020 (r364221) > @@ -0,0 +1,53 @@ > +/*- > + * Copyright (c) 2020 Dell EMC > + * All rights reserved. I am not sure where your copying the copyright from, but in all known in tree templates the "All rights reserved." line has been removed. Your probably just copying it from another file perhaps? Or is this something Dell/Emc is requireing? > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > + * SUCH DAMAGE. > + * > + * $FreeBSD$ > + */ > + > +#include > + > +#include > + > +ATF_TC_WITHOUT_HEAD(sa_19_20_bsnmp_test); > +ATF_TC_BODY(sa_19_20_bsnmp_test, tc) > +{ > + struct asn_buf b = {}; > + char test_buf[] = { 0x25, 0x7f }; > + enum asn_err err; > + asn_len_t len; > + u_char type; > + > + b.asn_cptr = test_buf; > + b.asn_len = sizeof(test_buf); > + > + err = asn_get_header(&b, &type, &len); > + ATF_CHECK_EQ(ASN_ERR_EOBUF, err); > +} > + > +ATF_TP_ADD_TCS(tp) > +{ > + ATF_TP_ADD_TC(tp, sa_19_20_bsnmp_test); > + return (atf_no_error()); > +} > -- Rod Grimes rgrimes@freebsd.org