From owner-svn-src-head@freebsd.org Fri Aug 25 14:32:16 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 507ADDD9C0A; Fri, 25 Aug 2017 14:32:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2DBE035C1; Fri, 25 Aug 2017 14:32:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 58C4E10AF07; Fri, 25 Aug 2017 10:32:08 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322824 - in head: lib/clang share/mk usr.bin/clang Date: Thu, 24 Aug 2017 13:32:37 -0700 Message-ID: <55772661.irLqry82cl@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201708232330.v7NNUPpV052276@repo.freebsd.org> References: <201708232330.v7NNUPpV052276@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Fri, 25 Aug 2017 10:32:08 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 14:32:16 -0000 On Wednesday, August 23, 2017 11:30:25 PM John Baldwin wrote: > Author: jhb > Date: Wed Aug 23 23:30:25 2017 > New Revision: 322824 > URL: https://svnweb.freebsd.org/changeset/base/322824 > > Log: > Improve the coverage of debug symbols for MK_DEBUG_FILES. > > - Include debug symbols in static libraries. This permits binaries > to include debug symbols for functions obtained from static libraries. > - Permit the C/C++ compiler flags added for MK_DEBUG_FILES to be > overridden by setting DEBUG_FILES_CFLAGS. Use this to limit the debug > information for llvm libraries and binaries. > > Reviewed by: emaste > Sponsored by: DARPA / AFRL > Differential Revision: https://reviews.freebsd.org/D12025 This does increase the size of installed worlds when MK_DEBUG_FILES=yes is enabled (which is the default). On amd64 and mips64 the libraries in /usr/lib and /usr/lib32 each increased by about 150MB to 300MB. The debug info for binaries in /usr/bin (which is stored in /usr/lib/debug/usr/bin) increased another 300MB or so for a total increase of ~900MB. Most of the increase was in llvm binaries (clang, lld, lldb), but the svnlite binaries also have more debug info since previously we were not geneating debug info for private libraries. Without the changes to use -gline-tables-only/-g1 for llvm libraries and binaries the amd64 world increased by almost 4GB with most of that increase in the debug info for clang, lldb, lld, and llvm-tablegen. One thing that might make this less painful in the future is being able to use compressed debug symbols. -- John Baldwin