From nobody Wed Jul 9 08:59:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bcX312CJYz61N2Z; Wed, 09 Jul 2025 08:59:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bcX306qthz3ccM; Wed, 09 Jul 2025 08:59:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752051549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OIisq4u4Qiunf3hEs5i7FrBAw93QTuPEBEXfkhBngZ4=; b=Tc4vpOONNKI5M4rHTExD2+pq0p1Cmo98d/i2AyolOzHLqlJmHXG1imO5aXf4I8NsUAqU3L g7V58pHoK72pNXzFsXfRebyMsODtpEIjUvCXwaYUmckjvwmnGE7a21l4i3FjMhzqyFChhs zHZvfL+kDV7IX2J0zoy3MvOafOLo4yGJch5B8GNBX47cs7SDt9mBydAmdYwFZsPz0HKKOc lMHaNx/lkoTGX6/jGrnNBgv1niBFM3XUKkvC6SBKMGP4G49521VnElOAsOQR/CaFcaXB5T g67QulAbq09lLlgW37LHhQiqRDkcrrIe7wjoOVa0tkECLBxIOsPujH6MURcbqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752051549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OIisq4u4Qiunf3hEs5i7FrBAw93QTuPEBEXfkhBngZ4=; b=pvvPtlmvHoRH2nrXKZ32mt4iNb/osHSyXPrQsdFvQLwWFye3Kevz3PifTXn3RaRwY7ArN5 b2SbWEGT2CAUSgCt3MxJXeZ8pqcGgec5HhTq9UoNOOm3KOyqwzdOmvJGoi8sLrJj6CeZEl 6odd9NkU/8eit+kyZOPU3M/d4VCAoOjb3q29Yk48lW/b0rSJM8JWOEsq+Jo8kOiClH5hR0 8n99tXkcrzJFtZN/+tbKPqWrOZEgKGibNvf+QkuYTrwe9OIEcNo4uz/a7uef/cWsrzMsa+ boCjp4EA4FqbL99Im8MDUtcfQ1zs3097CNut3/0uFG0zYLRh3W8iLuRvF35JbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752051549; a=rsa-sha256; cv=none; b=fLHAEkX5B6uppNJ1MKVxM+Fx8TD/Z1pwremBASQ54wAGCAlsW57RpuWRjf5vcg1S6ur8aY 4QdSSlv2Tm1CTlG+xx+m2IMqhn0p5+LFdXqhOy8zmq/6KgP3P/tKP2DZbWbfr659SiLWtu vSEsiW3JEgSo3Mq1QAOTYAXhsc3WX88w5j0zfAPVGlmNx7qJrRUEuyQS4feanTAtMorxHq hVqu89ycZwELA+VoArwwNXvJC3/UhGGAWWYGnsiI+uRr7lkSXxeWEEdXVzXgzSON6wMFVF TvjOcogBoS/IPcOkqTtAbaeqxKCbGVToFGthWJlp6YK8AoMPHc6LQ4w//mrUag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bcX3066xXz4v; Wed, 09 Jul 2025 08:59:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5698x8gA045030; Wed, 9 Jul 2025 08:59:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5698x8Q8045027; Wed, 9 Jul 2025 08:59:08 GMT (envelope-from git) Date: Wed, 9 Jul 2025 08:59:08 GMT Message-Id: <202507090859.5698x8Q8045027@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 6b95d258a96b - main - pf tests: test DIOCNATLOOK validation List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b95d258a96b7f3a7d61af5c3fb028194ca8f204 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=6b95d258a96b7f3a7d61af5c3fb028194ca8f204 commit 6b95d258a96b7f3a7d61af5c3fb028194ca8f204 Author: Kristof Provost AuthorDate: 2025-07-03 15:07:52 +0000 Commit: Kristof Provost CommitDate: 2025-07-09 08:57:49 +0000 pf tests: test DIOCNATLOOK validation Sponsored by: Rubicon Communications, LLC ("Netgate") --- tests/sys/netpfil/pf/ioctl/validation.c | 35 +++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/tests/sys/netpfil/pf/ioctl/validation.c b/tests/sys/netpfil/pf/ioctl/validation.c index 1ce8999dcb91..18fafe11c6ab 100644 --- a/tests/sys/netpfil/pf/ioctl/validation.c +++ b/tests/sys/netpfil/pf/ioctl/validation.c @@ -32,6 +32,7 @@ #include #include +#include #include #include @@ -893,6 +894,39 @@ ATF_TC_CLEANUP(rpool_mtx2, tc) COMMON_CLEANUP(); } +ATF_TC_WITH_CLEANUP(natlook); +ATF_TC_HEAD(natlook, tc) +{ + atf_tc_set_md_var(tc, "require.user", "root"); +} + +ATF_TC_BODY(natlook, tc) +{ + struct pfioc_natlook nl = { 0 }; + + COMMON_HEAD(); + + nl.af = AF_INET; + nl.proto = IPPROTO_ICMP; + nl.saddr.v4.s_addr = 0x01020304; + nl.daddr.v4.s_addr = 0x05060708; + + /* Invalid direction */ + nl.direction = 42; + + ATF_CHECK_ERRNO(EINVAL, ioctl(dev, DIOCNATLOOK, &nl) == -1); + + /* Invalid af */ + nl.direction = PF_IN; + nl.af = 99; + + ATF_CHECK_ERRNO(EAFNOSUPPORT, ioctl(dev, DIOCNATLOOK, &nl) == -1); +} + +ATF_TC_CLEANUP(natlook, tc) +{ + COMMON_CLEANUP(); +} ATF_TP_ADD_TCS(tp) { @@ -918,6 +952,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, tag); ATF_TP_ADD_TC(tp, rpool_mtx); ATF_TP_ADD_TC(tp, rpool_mtx2); + ATF_TP_ADD_TC(tp, natlook); return (atf_no_error()); }