From owner-freebsd-current@FreeBSD.ORG Tue Jun 2 12:12:39 2009 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED2DD106567E for ; Tue, 2 Jun 2009 12:12:39 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 8BCEE8FC1F for ; Tue, 2 Jun 2009 12:12:39 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from outgoing.leidinger.net (pD9E2E94E.dip.t-dialin.net [217.226.233.78]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id D4323844F47; Tue, 2 Jun 2009 14:12:37 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id A76A0296122; Tue, 2 Jun 2009 14:12:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1243944752; bh=2ItUlgunTvfx0Rcl3DHYDb4RUVxQjp1tFWa+V96vLmM=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=QigG8zGfKnPbREnLCyZSrCNf10pO4gYWAbgheN1xlsH7FlObiaZGjZfj6HTXSUOZV khAw867q53fr1Fji2idn3A08FDJgUVnIalWuLS3X5jeMzMa889+hwTQl3uS+berDkl XMYokFoQqA9aDFE3u3OJ5c5E1HVsi0TqeeOmG1k3AsPqT1JyD4JvxtgagEpgH3Nwj3 kmdwkAj/JWlThupAP9S4V/cpLm3Qo+n5+gDHYolpwIazsMTvSQ9uk4/Sm6gYdKSFO1 hRm2kD0QdVES5V3TeaM5y3wgDyg680IB0VabfJB71Q13vI0ZKYawK1J78zEdFrQIuc h8gbmULt80ykg== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id n52CCWxW005755; Tue, 2 Jun 2009 14:12:32 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Tue, 02 Jun 2009 14:12:31 +0200 Message-ID: <20090602141231.67987dnz529yuqgw@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Tue, 02 Jun 2009 14:12:31 +0200 From: Alexander Leidinger To: Doug Barton References: <4A23D5A4.6020009@icyb.net.ua> <4A23F4B8.7000002@freebsd.org> <4A240331.1000803@FreeBSD.org> In-Reply-To: <4A240331.1000803@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) 4.3.3 / FreeBSD-8.0 Cc: freebsd-current@FreeBSD.org, Andriy Gapon Subject: Re: fsck_y_enable: use -C X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2009 12:12:42 -0000 Quoting Doug Barton (from Mon, 01 Jun 2009 =20 09:34:57 -0700): > Andriy Gapon wrote: >> on 01/06/2009 16:20 Andriy Gapon said the following: >>> What about the following patch? >>> I believe that the idea behind fsck_y_enable is to try to make =20 >>> unattended systems >>> with rw filesystems as recoverable as possible at the cost of =20 >>> potential damage to >>> the data. The new "-C" option should not interfere with this goal, =20 >>> but should >>> reduce recovery time, because currently fsck -y checks *all* =20 >>> filesystems from >>> fstab, even those that are ro or clean: >>> >>> -C Check if the =E2=80=9Cclean=E2=80=9D flag is set in the superblo= ck and skip file >>> system checks if file system was properly dismounted and marked >>> clean. >>> >> >> One potential issue that I've just thought of is that fsck_msdosfs =20 >> doesn't seem to >> support this option (even in a dummy way), so it would be a problem =20 >> for those who >> have msdos filesystems in fstab and also have fsck_y_enable. > > I'm a bit concerned that we keep the current option as it is, but I > would support adding an fsck_y_enable_flags option to allow people to > pass -C if they are sure it will work in their environment. What about _flags and also adding a NOP for -C in fsck_msdosfs? Bye, Alexander. --=20 Another dream that failed. There's nothing sadder. =09=09-- Kirk, "This side of Paradise", stardate 3417.3 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137