From owner-freebsd-ports Thu Apr 27 11:55:32 2000 Delivered-To: freebsd-ports@freebsd.org Received: from mail.enteract.com (mail.enteract.com [207.229.143.33]) by hub.freebsd.org (Postfix) with ESMTP id A9CBD37B705 for ; Thu, 27 Apr 2000 11:55:29 -0700 (PDT) (envelope-from edulzo@enteract.com) Received: from shell-1.enteract.com (edulzo@shell-1.enteract.com [207.229.143.40]) by mail.enteract.com (8.9.3/8.9.3) with SMTP id NAA13094 for ; Thu, 27 Apr 2000 13:55:28 -0500 (CDT) (envelope-from edulzo@enteract.com) Date: Thu, 27 Apr 2000 13:55:28 -0500 (CDT) From: Kevin and Elizabeth Dulzo Reply-To: kdulzo@gerp.org To: freebsd-ports@freebsd.org Subject: Xpm & XFree86-4 Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org I have currently become a little irritated with the dependency not found issue when using Xpm based ports with XFree86-4. As well, a grep xpm /usr/ports/INDEX | wc shows 413 ports that require Xpm libraries. Would it seem prudent to add a USE_XPM to bsd.port.mk to make this easier? As well, it would then seem to have a make.conf entry for those of us who do use XFree86-4 for something like USE_XFREE86_4 which both deals with depending on /usr/ports/x11/XFree86-4 and eliminates xpm specific dependencies when using XFree86-4. I have tested this on xemacs21 and so far it seems to function as expected. I have a patch for bsd.port.mk that I can submit to pr if that is the way to get a committer to ponder the change. For any ports that do not appear to work with version 4.x, an if defined(USE_XFREE86_4) BROKEN= could deal with that (that seemed to be the trend in other ports...). Anyone else think this is a good idea? Anyone ever note that comment above the USE_XLIB line that doesn't make any sense in regards to the actual effect the variables have???? --- bsd.port.mk.orig Thu Apr 20 10:46:17 2000 +++ bsd.port.mk Thu Apr 27 13:29:02 2000 @@ -680,6 +680,16 @@ MANCOMPRESSED?= no .endif +# Deal with XFree86-4.x having Xpm support. +# USE_XPM implies USE_XLIB +.if defined(USE_XPM) +.if defined(USE_XFREE86_4) +USE_XLIB= yes +.else +LIB_DEPENDS+= Xpm.4:${PORTSDIR}/graphics/xpm +.endif +.endif + .if defined(USE_QT) LIB_DEPENDS+= qt.3:${PORTSDIR}/x11-toolkits/qt145 USE_NEWGCC= yes @@ -767,7 +777,11 @@ # Don't try to build XFree86 even if ALWAYS_BUILD_DEPENDS is defined -- # it's just too big.... .if defined(USE_XLIB) && !defined(ALWAYS_BUILD_DEPENDS) +.if defined(USE_XFREE86_4) +LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86-4 +.else LIB_DEPENDS+= X11.6:${PORTSDIR}/x11/XFree86 +.endif .endif .if exists(${PORTSDIR}/../Makefile.inc) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message