From owner-svn-src-head@freebsd.org Mon Nov 12 02:40:40 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55857112DF7E; Mon, 12 Nov 2018 02:40:40 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC6A979EFA; Mon, 12 Nov 2018 02:40:39 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f177.google.com with SMTP id k206-v6so10603522ite.0; Sun, 11 Nov 2018 18:40:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=YvNzooep6lJJLuGd/8fW1HsF6EL5oiqP+ssnT6rBU7A=; b=AaoXQVH0XqRgoWGgTiGkHKG0EDQWkPGfHhU05XjO8MsNQ6hxWEHtunEmG5++GJ1Fm+ Y1uHZ/6vWqjgi33QbaqphSHTjsY34WA7Vv3mYFLTitCGexER8QmxbUZYyeCy73zBVPjH lbliOjijAqLJA9ztJfsl12av3iXukLZ3pEfKaOoepQbP2xEX4qEP4Q9TPMJNhQq9c3uG Kwi2s3lM+w+egiQOgquY+Zm+8Xo4qx8eG49ipmv/9jubgTO5xDmhJEow4gJk2Zd9GtnZ QXipIEXZnf5DkqycNGJTmO4N1sxHrbE+N9xm/ub/+1L3vQFR5+FBkIrV+++3d2YBoIAw 3Z8w== X-Gm-Message-State: AGRZ1gKIHEQbt/7DzGhkVm9eMgHu0qj2QgjsLjFlz+zDLPiQvTxv9slq XULuVhODVh+LB6FckOy98Gse/Ye5 X-Google-Smtp-Source: AJdET5fwG0svyonAV/p1TkDu5fVFsdFXziXvgFJ8iJTKv5JMHxOSvcUerKcePSBTrOQ4wRb6IigHHA== X-Received: by 2002:a02:95cb:: with SMTP id b69-v6mr16826647jai.120.1541989940654; Sun, 11 Nov 2018 18:32:20 -0800 (PST) Received: from mail-it1-f180.google.com (mail-it1-f180.google.com. [209.85.166.180]) by smtp.gmail.com with ESMTPSA id n25-v6sm4503075iop.34.2018.11.11.18.32.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Nov 2018 18:32:20 -0800 (PST) Received: by mail-it1-f180.google.com with SMTP id w7-v6so11204046itd.1; Sun, 11 Nov 2018 18:32:19 -0800 (PST) X-Received: by 2002:a24:c846:: with SMTP id w67-v6mr9815580itf.32.1541989939211; Sun, 11 Nov 2018 18:32:19 -0800 (PST) MIME-Version: 1.0 References: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 11 Nov 2018 18:32:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r340326 - head To: "Rodney W. Grimes" Cc: woodsb02@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: AC6A979EFA X-Spamd-Result: default: False [-4.01 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; RCVD_COUNT_THREE(0.00)[4]; REPLYTO_ADDR_EQ_FROM(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.88)[-0.885,0]; RCVD_IN_DNSWL_NONE(0.00)[177.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; IP_SCORE(-1.12)[ipnet: 209.85.128.0/17(-3.56), asn: 15169(-1.92), country: US(-0.09)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 02:40:40 -0000 I absolutely approve of Ben's excellent addition to UPDATING, a text document. Your demands for additional scrutiny and time-wasting around code review are ridiculous and disproportionate, and certainly a poor reward for Ben's straightforward and unimpeachable effort to improve our UPDATING documentation. Ben, thank you for submitting and committing the UPDATING change and please try to ignore Rod's hyper-criticism. Conrad On Sat, Nov 10, 2018 at 5:07 PM Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > If your going to bother with a differential, and invite people to > > > it you should give them at least 24 hours, and preferably 72 hours > > > to respond to the new review. Reviews that last < 4 hours are not > > > code reviews. > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > Hi Rod, > > > > Sorry. The main reason I submitted the code review is because I do not have > > my src commit bit, so needed to seek approval to commit. > > All the more reason for it to wait until the people you *invited* to > the review to have a chance to respond. > > I do not believe an "accept" in a review is an "approve to commit > beyond your normal scope". > > Was cem aware that he was "approving a non src committer to commit > this change to the src tree" as your review has no mention that you > are seeking src bit approval to commit there. > > > > > I felt the need to commit the UPDATING entry was time sensitive, given the > > change it was notifying users of had already been committed. > > > > Regards, > > Ben > > -- > > -- > Rod Grimes rgrimes@freebsd.org >