Date: Wed, 23 May 2007 13:37:33 -0400 From: John Baldwin <jhb@freebsd.org> To: Andrew Gallatin <gallatin@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c Message-ID: <200705231337.35056.jhb@freebsd.org> In-Reply-To: <200705231531.l4NFV12H058289@repoman.freebsd.org> References: <200705231531.l4NFV12H058289@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 23 May 2007 11:31:01 am Andrew Gallatin wrote:
> gallatin 2007-05-23 15:31:01 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/pci pci_pci.c
> Log:
> Fix a typo in pcib_alloc_msi{x} which resulted in the
> device's, not the bridge's, softc to be used to check the
> PCIB_DISABLE_MSI flag. This resulted in randomly allowing
> or denying MSI interrupts based on whatever value the driver
> happened to store at sizeof(device_t) bytes into its softc.
>
> I noticed this when I stopped getting MSI interrupts
> after slighly re-arranging mxge's softc yesterday.
Doh, thanks for fixing!
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705231337.35056.jhb>