From owner-svn-src-all@freebsd.org Tue Feb 12 01:25:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC13514EB881; Tue, 12 Feb 2019 01:25:37 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1AEA994384; Tue, 12 Feb 2019 01:25:35 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1C1PXWP073632; Mon, 11 Feb 2019 17:25:33 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1C1PX7G073631; Mon, 11 Feb 2019 17:25:33 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902120125.x1C1PX7G073631@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net In-Reply-To: To: Patrick Kelsey Date: Mon, 11 Feb 2019 17:25:33 -0800 (PST) CC: John Baldwin , rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 1AEA994384 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [2.17 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.65)[0.654,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.01)[ip: (0.02), ipnet: 69.59.192.0/19(0.01), asn: 13868(-0.02), country: US(-0.07)]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; NEURAL_SPAM_LONG(0.03)[0.028,0]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_SPAM_MEDIUM(0.61)[0.611,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 01:25:38 -0000 > On Mon, Feb 11, 2019 at 8:08 PM John Baldwin wrote: > > > On 2/11/19 4:26 PM, Rodney W. Grimes wrote: > > >> Author: pkelsey > > >> Date: Mon Feb 11 23:24:39 2019 > > >> New Revision: 344027 > > >> URL: https://svnweb.freebsd.org/changeset/base/344027 > > >> > > >> Log: > > >> MFC r343291: > > >> Convert vmx(4) to being an iflib driver. > > > > > > I strongly object to this MFC, given the current number > > > of 12.0 RELEASE related iflib problems we have it is > > > foolish of us to iflib any more drivers in 12.0 > > > > This isn't the release branch though and presumably we have some time > > before > > 12.1 ships. If there are reports of vmx(4) breakage on stable before 12.1 > > we could always revert this commit then? > > > > I've heard of some EN's for 12.0 for iflib fixes. Are those fixes in > > stable/12 > > yet or are we still waiting for them to land in HEAD and/or be merged? > > > > iflib.c is currently the same between head and stable/12. I've found and > fixed a number of iflib bugs by developing the iflib version of the vmx(4) > driver, and it's also being fielded in a product. I'm also aware that not > all current driver problems are necessarily iflib problems. I think we'd > be better off letting this version of vmx(4) ride it out in stable/12 until > such time as we discover an actual horror that we then feel we need to > react to in some way other than just going ahead and fixing it. It can ride it out in head just fine, give it 3 months... plenty of time before any 12.1. stable/12 IS NOT A TEST GROUND. -- Rod Grimes rgrimes@freebsd.org