From owner-svn-src-all@freebsd.org Tue Jun 18 19:50:17 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4DA715C7072 for ; Tue, 18 Jun 2019 19:50:16 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 737508BB20 for ; Tue, 18 Jun 2019 19:50:16 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x832.google.com with SMTP id x47so16904888qtk.11 for ; Tue, 18 Jun 2019 12:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=29JWM0Pxrxj4fV4pnsKEkZtLL+duE6vapPje6UqJVJ8=; b=UT31D//jl6Hz9CaYQyf29Xg8SMzH3JjovKdDH0DkSgYskPEc3t51XqeSMO0zhAcJjr Gn40b9BX/EO1NiMN5HoZm+7mEqs5GmG6pBVlZrwprWrgsVuU6qBO++KwYwyleCnbK+51 bIOLIRRlLDMDM9/GseuEKbxAMV9wf4MSNPbpfapk5mBjbSofw2yWsPOE+EhKhSD5T/lg acHHs460qZO22yjNWrFtPWsdgOKX9YQUz2qsEEDKE4uBxQw7rc+ntnbfv2+BfsMexuRU GmZLJB15vL4VsV6MbGaAxegb0mIDCtrfb+MLXxftAucHWnuo63MvGsA9fWS90C9uWOuZ pc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=29JWM0Pxrxj4fV4pnsKEkZtLL+duE6vapPje6UqJVJ8=; b=ByO1IA7giBZEQjPQ8qZkz9/ylkQeuyrCnSPA0Ki+S0iWhTMKRbv3J7VlCXEdkI8v7I 3E0eDz679ya5IL8akFgZJZ6i2kJ2Xge1pmY24Q7Pk50BTrZNm2qwRgBEg7BVHRRu0GIo Svcmr5w948CVuFSDNcFtaeSe7MwP3DRNydvFxdfpcbHxDjRcbGBPEbp4CCgIWOZrQeUJ Mrtj0M4+NDIi08KKLwuppBSrRYRgJQNecQKoZVRhxIh0zq/SguIwtNL5+vIrhUb5kWjn O4+8sfsODRxSgvhTDVHor7wp1oeC88ucU7XcighVnH24gAUAJUZGw8WJqKqIJCb1uYs3 lWPg== X-Gm-Message-State: APjAAAUM4hdZtVyLVut1jRWiw9fRzEEICCuDXgoy5C4vhGAmGsPRsQq5 2pe7OURgkLutgsJJTDlfw7dRYEyirpA= X-Google-Smtp-Source: APXvYqzEZ+a7IMZRzLLMcMPI94jQaQhVaMTQY3Y1EE4iVVZxZqOofAtUQE6yYBhSUQHMT4+mAyN+Kw== X-Received: by 2002:ac8:f13:: with SMTP id e19mr100585097qtk.11.1560887415629; Tue, 18 Jun 2019 12:50:15 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id q29sm9158005qkq.77.2019.06.18.12.50.14 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 12:50:14 -0700 (PDT) Date: Tue, 18 Jun 2019 15:50:14 -0400 From: Shawn Webb To: Cy Schubert Cc: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349176 - head/sys/dev/random Message-ID: <20190618195014.utsmhhmgzrj6gqlv@mutt-hbsd> References: <20190618185512.e2nbzwbtvxz2azge@mutt-hbsd> <201906181946.x5IJkiJ5003201@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jq3dnxqekadefzxt" Content-Disposition: inline In-Reply-To: <201906181946.x5IJkiJ5003201@slippy.cwsent.com> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD HARDENEDBSD-13-CURRENT amd64 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 737508BB20 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 19:50:17 -0000 --jq3dnxqekadefzxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 18, 2019 at 12:46:44PM -0700, Cy Schubert wrote: > In message <20190618185512.e2nbzwbtvxz2azge@mutt-hbsd>, Shawn Webb=20 > writes: > >=20 > > --mmc352mzirnzscxj > > Content-Type: text/plain; charset=3Dus-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Tue, Jun 18, 2019 at 06:50:58PM +0000, Conrad Meyer wrote: > > > Author: cem > > > Date: Tue Jun 18 18:50:58 2019 > > > New Revision: 349176 > > > URL: https://svnweb.freebsd.org/changeset/base/349176 > > >=3D20 > > > Log: > > > random(4): Fix a regression in short AES mode reads > > > =3D20 > > > In r349154, random device reads of size < 16 bytes (AES block size)= were > > > accidentally broken to loop forever. Correct the loop condition fo= r sm=3D > > all > > > reads. > > > =3D20 > > > Reported by: pho > > > Reviewed by: delphij > > > Approved by: secteam(delphij) > > > Differential Revision: https://reviews.freebsd.org/D20686 > > > > Hey Conrad, > > > > Thanks for fixing this issue! Any plans to MFC? >=20 > Why? Whoops. I didn't catch the condition on the revision number. Sorry for the line noise! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --jq3dnxqekadefzxt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0JQHEACgkQ/y5nonf4 4fqiIA/9GOZEF0ToYa5JYa/C/4Dl6Qnw+NY0KRjSe4O3cZY/VouM2CblfT+neqi+ xmRnFG0fmesKsbOMoPbgYh96MQ7/FkSA3Od73Ilv8OCjtF1eEWJH0HusFai3iHcW pvdVn3qjiCp3tGbpxj/nJSEeZnAkKZF7sRS+wLL50Ihv68O7Wy/3B+fdmY4VvWO4 NNV96BbmLna3MT8logMDrcb3vhIy/tf1u8Lvvbg+zAMjsriSXTatRRbavzXOLTyG R21zNCDe5gDxsxUnTJ0vQDAvoP0GVdlGR/0FHAop+r6/FBtjbWh4g8XlGlyHnR3r 1QqIHiatWueyAzltXtpGwvVD66faTFHSOZ9LZzwA/YCBdV3W38I0yGZ9mVHFHvyu zfJPCd5/3ZZ1+X1ODfDaX0F8KQydnhn+70wBbXYhnKfGRCtAIo6kTB77U20yqCWi L6eH0sfOvkFbQuXwTRylSvDimm8XX2NV9cIWk4c+E7Q4Htcotl5aPntwiUMJO0qo kuzwqnalCzXkCoFi5eUK3/RAr3g1xkYBIt2oYfrUojnThQr7aZTvMFF4OBzUjoLI /SOeMqeOqexSOhIxfqNtMajhjg0HNKd/kvtbynlEWMGkBkITzr1BP1ZCXI0EUIG0 OfIDwdYGibVBa0Wc3sZ+IWCxkRoqNzIALFoDUL1nc3QbRovxo8k= =KspM -----END PGP SIGNATURE----- --jq3dnxqekadefzxt--