From owner-freebsd-git@freebsd.org Sat Feb 27 02:23:21 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0376B5581C8 for ; Sat, 27 Feb 2021 02:23:21 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnVgW6kxqz3lqQ; Sat, 27 Feb 2021 02:23:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pj1-x102f.google.com with SMTP id e9so7198289pjj.0; Fri, 26 Feb 2021 18:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+BV/rffiP8OW4Kg/myb9P26KrXphUycBIwQ91vDGhJI=; b=SP1AY29UekpGRSkpHBk5WlP3JJEdGbfRmXkWfW5DkZRPM9CjYmabpINegHlb95s+jr jSae5JQXptctTRPRyGu2zbYZhASmx/WxjP+tfOI9b4vxCO+709YeuXYOAYnlkDMWqnsr vHFYQSz6MCWYx+aXi0O2ICwJF1PvvabZgWWWwYeafPBFYtUAVaXMFoDQoNOu8PQdvLEp /dN6fdFkqtqxYZpbH72pGc1y6LsGf+E95I9OwvjEDjMhqK4dFHfjPVqR5njL8pigWbFi +vttrZ/KcmXq6iQ0qn2w5nEbLcVYl29ov+8W/zFHo4SI6NoLZvyhBoCgCiAmaVN4FlZJ 486A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+BV/rffiP8OW4Kg/myb9P26KrXphUycBIwQ91vDGhJI=; b=FeFYk4w8Aom7cPk5jXUMY16rcPxn2msjq6AMEQAPX7ZVUC065GyTTwpHXyGN7FoLsZ rCjCFI+8NWzdKs5a2K5Tw+lrPApIHHX57SarQe1/a3srr54K2mbbsIasMjo+U4QVW5J6 8DjovLtaxdg91xuJAP4gVeSZ3tgZn6ooWlT5h4clpiyDZki1r7iyEV43Qf7JvPwiA8DQ MeCRY9zfqq1OEY3SvCJkXfZ6sZDOvxh02ik0FhFU5JZSYo5wYR3qOD++92qriRaHsAWS y1GqDF91PPsoUhK1LhrpN8N/1GEOZAHNFVxMB9SI5eLOitPKs9eJeKSCYPlilBYb/+X1 2KsA== X-Gm-Message-State: AOAM531QFYpvgmsrwMOxsOlKcQED2OI5QlRuRTJoxlUiOlIOvbyEVcYE dl+qKgtKCwiSOZcLcCAmQiaNJ4szB8w= X-Google-Smtp-Source: ABdhPJzbrl0GFo+dfFiteqDgu6CN3/4Q3lNve2Qww5ByFbAxOJJXFVIs6O8d9z9eDTPc7c0b70xRgg== X-Received: by 2002:a17:90b:1284:: with SMTP id fw4mr6212845pjb.157.1614392598237; Fri, 26 Feb 2021 18:23:18 -0800 (PST) Received: from ?IPv6:2403:5800:7500:3601:6c96:2af:6952:e9bc? (2403-5800-7500-3601-6c96-2af-6952-e9bc.ip6.aussiebb.net. [2403:5800:7500:3601:6c96:2af:6952:e9bc]) by smtp.gmail.com with UTF8SMTPSA id q95sm130014pjq.20.2021.02.26.18.23.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Feb 2021 18:23:17 -0800 (PST) Sender: Kubilay Kocak Message-ID: <5695f4e8-3f05-c7f6-6ddc-7ad3b2a5a091@FreeBSD.org> Date: Sat, 27 Feb 2021 13:23:14 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Thunderbird/88.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: Adopting "Fixes" trailer Content-Language: en-US To: Ed Maste , John Baldwin Cc: freebsd-git References: <75c9ad1e-c7ca-8a22-cfe5-6434b3685ccc@FreeBSD.org> From: Kubilay Kocak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DnVgW6kxqz3lqQ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=SP1AY29U; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-1.20 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::102f:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_SPAM_SHORT(1.00)[0.999]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::102f:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102f:from]; MAILMAN_DEST(0.00)[freebsd-git] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2021 02:23:21 -0000 On 19/02/2021 6:30 am, Ed Maste wrote: > On Thu, 18 Feb 2021 at 11:53, John Baldwin wrote: >> >>> https://reviews.freebsd.org/D28693 >> >> Huh, at first I thought this was to auto-close issues on GitHub. I think >> this is a good idea. If we had a wrapper script for MFC's it could >> auto-squash those as an option perhaps. > > Ah, I think that's typically "Closes: " > > Indeed we could search for Fixes in an MFC wrapper; the MFC reminder > mails and https://gitmfc.kernelnomicon.org could also be extended to > list related Fixes commits. Fixes/Closes & References within commit log messages are common keywords to close, and add comments to (respectively) to issues (as properties: or trailers, or within commit bodies (non trailer)) It would be nice to reserve/use those for issue tracker integration/automation. One possible dual-use is "References[:] " but the value parsing ambiguity between a commit hash and issue number can sometimes cause problems or be less than robust. (that ive seen from other projects) > It is used to identify a commit that is a follow-up bug > fix to a previous commit, and could generally be used instead of "MFC with" > or "X-MFC-with". One nice aspect is that it conveys fix metadata also for > commits that aren't intended for MFC, which may be useful for downstream > projects. Could you clarify this use case, and provide a couple of examples? Sounds like we want a way to link/ref/relate a sequence or particular set/series of commits so they can be identified as logically/functionally related, so as to take a consistent set of actions with them as a group (merge, or anything else) Is that a decent summary?