From owner-freebsd-multimedia@FreeBSD.ORG  Wed May  4 03:41:36 2005
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D2BBC16A4CE
	for <freebsd-multimedia@freebsd.org>;
	Wed,  4 May 2005 03:41:36 +0000 (GMT)
Received: from mail231.csoft.net (resin.csoft.net [63.111.22.86])
	by mx1.FreeBSD.org (Postfix) with SMTP id 44AE943D3F
	for <freebsd-multimedia@freebsd.org>;
	Wed,  4 May 2005 03:41:36 +0000 (GMT)
	(envelope-from jakemsr@jakemsr.com)
Received: (qmail 29778 invoked from network); 4 May 2005 03:47:41 -0000
Received: from unknown (HELO puff.jakemsr.gom) (63.111.27.87)
  by mail231.csoft.net with SMTP; 4 May 2005 03:47:41 -0000
Received: (from jakemsr@jakemsr.com)
	by puff.jakemsr.gom (mini_sendmail/1.3.5 16nov2003);
	Tue, 03 May 2005 20:41:32 PDT
	(sender jakemsr@puff.jakemsr.gom)
Date: Tue, 3 May 2005 20:41:32 -0700
From: Jacob Meuser <jakemsr@jakemsr.com>
To: freebsd-multimedia@freebsd.org
Message-ID: <20050504034132.GF27854@puff.jakemsr.gom>
Mail-Followup-To: freebsd-multimedia@freebsd.org
References: <20050502043610.51034.qmail@exxodus.fedaykin.here>
	<4275B154.5070007@ahze.net> <20050503070628.GF11140@puff.jakemsr.gom>
	<20050504003425.A97449@kushnir1.kiev.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050504003425.A97449@kushnir1.kiev.ua>
User-Agent: Mutt/1.4.2i
Subject: Re: New ffmpeg CVS versions
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>,
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>,
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2005 03:41:36 -0000

On Wed, May 04, 2005 at 12:48:52AM +0300, Vladimir Kushnir wrote:
> 
> 
> On Tue, 3 May 2005, Jacob Meuser wrote:
> 
> <snip>
> >
> >notes on grab_bsdbktr.c
> >
> <snip>
> > i think av_set_pts_info() needs to be moved up to before other
> > parameters in 's' are set in grab_read_header().
> 
> Actually, with av_set_pts_info() as it is grabbing doesn't work even in 
> the present ffmpeg port. It should be
> av_set_pts_info(st, 48, 1, 1000000);
> not
> av_set_pts_info(s1, 48, 1, 1000000);
> (as av_set_pts_info() takes AVStream and not AVFormatContext). With this 
> change ffmpeg grabs even without any move.

hmm, ok.  I didn't notice that.  thanks :)

-- 
<jakemsr@jakemsr.com>


> >
> > i'm pretty sure the av_free() in grab_read_close() can result in
> > double free errors, i.e. ffmpeg free()s the memory automagically.
> 
> Yep, it does.
> 
> Regards,
> Vladimir
> _______________________________________________
> freebsd-multimedia@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
> To unsubscribe, send any mail to 
> "freebsd-multimedia-unsubscribe@freebsd.org"