From owner-cvs-ports@FreeBSD.ORG Fri Oct 7 09:51:52 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23D0F1065675; Fri, 7 Oct 2011 09:51:52 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id CE2028FC22; Fri, 7 Oct 2011 09:51:50 +0000 (UTC) Received: by wwe3 with SMTP id 3so5284878wwe.31 for ; Fri, 07 Oct 2011 02:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=jKsvNbQBCkeSMKmpmlc+DtRCC2GDwvzB4mJGIh2TzCI=; b=EL7X1rDrhZM4yqaibS2ewlKMENsgbGQVjPTRnNbtHUTgX3b3mDqRNvj/tg99VLHIGR Vj39VHl5/oxmVKQDfSjqjFIsP232AD06JLCiAv/DOl2Yyp0lvIROsFq2q1hlgPjrWl6D G6Ot88BDbqXrAiMyIsP/Qs+/Vv/u/gqP02iJU= MIME-Version: 1.0 Received: by 10.227.150.207 with SMTP id z15mr2320564wbv.66.1317981109186; Fri, 07 Oct 2011 02:51:49 -0700 (PDT) Received: by 10.180.96.97 with HTTP; Fri, 7 Oct 2011 02:51:49 -0700 (PDT) In-Reply-To: <4E8E9A0F.8080208@FreeBSD.org> References: <201110061228.p96CSkxu017078@repoman.freebsd.org> <4E8E9A0F.8080208@FreeBSD.org> Date: Fri, 7 Oct 2011 05:51:49 -0400 Message-ID: From: "b. f." To: Alex Dupre Content-Type: text/plain; charset=ISO-8859-1 Cc: cvs-ports@freebsd.org, gerald@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/math/mpfr Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf1783@gmail.com List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2011 09:51:52 -0000 On 10/7/11, Alex Dupre wrote: > b. f. ha scritto: >>> From ${WRKSRC}/src/Makefile: >> >> libmpfr_la_LDFLAGS = $(MPFR_LDFLAGS) $(LIBMPFR_LDFLAGS) -version-info >> 5:0:1 >> >> So this should have included a libmpfr major version bump in the >> pkg-plist: > > No, sorry. We have the ltverhack exactly to avoid unneeded version bump. > Have you actually tried to build the port? Yes, of course, and it failed as I mentioned. But I see that I was a little too hasty in looking for the cause -- I am running recent -CURRENT, and the build was actually broken by: http://lists.freebsd.org/pipermail/svn-src-head/2011-October/030170.html which triggered a refresh build on my machine that installs the shared library with the wrong version number, which is what I saw when I looked at the tail of the build log. So the problem is not with this port, but with the hack that was added to /usr/share/mk/bsd.port.mk -- my apologies. > >> Also, I wonder >> if some of the dependent ports have come to depend, explicitly or >> implicitly, upon a thread-safe mpfr? > > Does my commit message say that I've disabled thread-safe support or > that I haven't enabled it? How am I to answer this rhetorical question? (I think that I might be forgiven for wondering in passing if the change has any consequence, since you brought it up in the commit message.) Your commit message says "Do not enable thread-safe support" -- as you well know -- but you have added an explicit "--disable-thread-safe" to CONFIGURE_ARGS. For the new version of the port, thread-safe support depends on the auto-detection of TLS support, but before it had to be explicitly enabled. So are you suggesting that if anything is broken by the lack of mpfr thread-safety, then it was already broken? If so, it would have been simpler just to say so. b.