From nobody Mon Jun 3 17:25:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VtLH90Qktz5Msn5 for ; Mon, 03 Jun 2024 17:26:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VtLH82wMxz4F6V for ; Mon, 3 Jun 2024 17:26:12 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42133f8432aso17477085e9.3 for ; Mon, 03 Jun 2024 10:26:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717435570; x=1718040370; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aotK3EbxMfIJbPwXG9b6gyGvEnCLD4+tut4M1NaEkW8=; b=DBaOvwiEqoFLNh3RfX9+QRpf6GKy0AqrhzG3v69X5jn37fvNK9SIAdOq8ppssbx7EG qzd15pb/ZyFmhhvO2b/XpB6dlkY2mmnS1tvmHTe2VLk7eK0a5Jc7IY3PPM+EougWdxib D/n5a9HhIFgJyGnBD7lyBrgP+ZXaoJMQwv7sqvRzyp7c2tpfIeVVz7Mp4zTTN0IeMmKr uVxo+oi/brN932kakJdvBC5ArIgWNi+dI+y8RqbWXokLfpOpg2UzOsHryHCerVrSGRmV bVnbz6jpWWNEbBx7pD23SxiXGB1UO87ZEkhD/cbI/gDqaJ128BMru9Iq7OuZCHXg7xzO HKNg== X-Forwarded-Encrypted: i=1; AJvYcCXr3HIZyL60Za7iTZ6KoMtwipHxyPvyvWaY3kBx7gBkin6FiP6T5Sts9goKZdh1RTpYr/tecUxFabVOJgfSRucyG/onoos8bfR0pYbQvj488A== X-Gm-Message-State: AOJu0YxHhjgiHFSQt+uTLk8HXR46LV85o1N4EAkTvyQROr1su4BGiPFr 8vDSkztPDCaNU5RFGqH3dZS5KrTOwesZcmdP1Xq2CsC3izOH1/8Hw098OFilNLs= X-Google-Smtp-Source: AGHT+IEXOOlSGiQ0e2oPMNJvI5I1LacTXMrv2Hl9GCUzRwNE8RAdAlvMP2weKvzMYPBZWPWFl9Roqw== X-Received: by 2002:a05:600c:4754:b0:421:2a0c:b5ad with SMTP id 5b1f17b1804b1-4212e049ccamr99693315e9.10.1717435570139; Mon, 03 Jun 2024 10:26:10 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04d9c73sm9287436f8f.58.2024.06.03.10.26.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2024 10:26:09 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: 077f757d72e5 - main - newfs_msdos: align data area to VM page boundary by default From: Jessica Clarke In-Reply-To: <202406021227.452CRx8I007470@gitrepo.freebsd.org> Date: Mon, 3 Jun 2024 18:25:59 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6D077B35-48BA-4516-BAB7-0B23CD3AB042@freebsd.org> References: <202406021227.452CRx8I007470@gitrepo.freebsd.org> To: =?utf-8?Q?Stefan_E=C3=9Fer?= X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.39 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.41:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.41:from] X-Rspamd-Queue-Id: 4VtLH82wMxz4F6V On 2 Jun 2024, at 13:27, Stefan E=C3=9Fer wrote: >=20 > The branch main has been updated by se: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D077f757d72e561eb84193d8e58f63e96= e69b8096 >=20 > commit 077f757d72e561eb84193d8e58f63e96e69b8096 > Author: Stefan E=C3=9Fer > AuthorDate: 2024-06-02 12:07:52 +0000 > Commit: Stefan E=C3=9Fer > CommitDate: 2024-06-02 12:07:52 +0000 >=20 > newfs_msdos: align data area to VM page boundary by default >=20 > Without alignment, the data area will not be aligned with the = buffer > cache, leading to overhead, higher write multiplication on SSD = devices > and issues with very large cluster sizes (see PR 277414). >=20 > The -A option used to align the start of the root directory to a > multiple of the cluster size, which happens to align the start of = the > data area with a buffer page boundary in case of large clusters and > the default number of directory entries (512 entries requiring 16 = KB > for FAT12 or FAT16, FAT32 puts the root directory into the data = area). >=20 > This commit aligns the start of the data area with the page size, = if > neither -A nor -r is used. It changes -A to align the start of the > data area (end of the root directory) to a multiple of the cluster > size, since this is the alignment that prevents write = multiplication > due to clusters crossing erase block boundaries of a SSD device. > The -r option is unchanged and will prevent any automatic alignment > from occuring. Hi, This has completely broken[1] all of the Linux and macOS cross-build CI jobs (which pass -DWITH_DISK_IMAGE_TOOLS_BOOTSTRAP). Please either fix this promptly or back it out until you can do so. Jess [1] See https://github.com/freebsd/freebsd-src/actions/runs/9338256762