From owner-svn-src-head@FreeBSD.ORG Thu Mar 3 20:04:02 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA676106566B; Thu, 3 Mar 2011 20:04:02 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9462E8FC0A; Thu, 3 Mar 2011 20:04:01 +0000 (UTC) Received: by wyb32 with SMTP id 32so1660455wyb.13 for ; Thu, 03 Mar 2011 12:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JnW8sgPjokYiizKyG+tsn8YyWBaczDj1DanzLTS7Igc=; b=ot20hOa86uGKAD5Uthh7xX2dOM/ZnCpZVsjo8gl1E7MxyaXFYU+m3KUmykfdTxrOdU 0szslvO3NNsCgv51mw2UTyqkKZi1YpvR2wxjx2lei6GIdrUuFsxobCxqUZD3uxrpHaIW Ad7aNo8PaAkHqydnmcgTf1+LrO8UtQUGtYETU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=TRJe6LmEos2AyHKdKZx2hrl2rz8b8dThqdNnF4tAxT6oRfLBj1SdujiuhaTjJt1yrx dcBdmGul6AXEh4IrcuoISRFVFd3DUCYU3j2qDqFNKnx9VLKWqXw0xt0ntdevd/oQY7Ba bLrxgeg9wPjmyVbYKKpuyTFS+dJ0bwz8/UBWY= MIME-Version: 1.0 Received: by 10.216.144.198 with SMTP id n48mr988405wej.75.1299182640394; Thu, 03 Mar 2011 12:04:00 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.172.7 with HTTP; Thu, 3 Mar 2011 12:04:00 -0800 (PST) In-Reply-To: <4D6FEE09.5050502@feral.com> References: <201103021606.p22G6vou020460@svn.freebsd.org> <201103031209.43857.jhb@freebsd.org> <4D6FCE64.3010302@freebsd.org> <201103031432.36336.jhb@freebsd.org> <4D6FEE09.5050502@feral.com> Date: Thu, 3 Mar 2011 12:04:00 -0800 X-Google-Sender-Auth: uag99Br-fnU9ITS7mesfm5Yx7fo Message-ID: From: Garrett Cooper To: Matthew Jacob Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Nathan Whitehorn , John Baldwin Subject: Re: svn commit: r219181 - head/release X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2011 20:04:02 -0000 On Thu, Mar 3, 2011 at 11:37 AM, Matthew Jacob wrote: > > >> I think it is a very important feature to ensure release builds are not >> polluted by local changes in /etc/src.conf, etc. =A0I think it would be = good >> to support both models perhaps, but for our official release builds I >> think >> we need the clean environment. =A0I certainly use 'make release' now for= my >> own custom FooBSD builds to get a clean environment. >> > While not disagreeing with you on this, one should really always do 'env = -i > PATH=3D/usr/bin:/bin make release' if you want to ensure non-pollution. It's more in-depth than that. The only way to ensure that the release builds are non-tainted without doing a ton of hacks is to create an untainted chroot/jail for the release build, or do the previous incantation in release/Makefile, as a number of components can taint the environment outside of PATH (see nanobsd's build scripts for a start on this). My personal preference is to have the scripts and infrastructure exist within release to do this instead of within release/Makefile, but this would require changes to any existing infrastructure that anyone depending on release/Makefile is employing out in the field; on the bright side maybe release/Makefile and nanobsd could converge because they'd be using more of the same logic to run things and the things that would truly differ are just the payload content. Thanks, -Garrett