From nobody Tue Feb 10 15:33:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9QZ22YHXz6RWLv for ; Tue, 10 Feb 2026 15:33:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9QZ14Jphz3GhN for ; Tue, 10 Feb 2026 15:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eIrFzy/+N6UpnWFqpWR5pLuHo0YPUtFUZNnEnRjEw54=; b=CV3DSFLNxN2xAo6Ae9UfqGszJ4f9Ka3A7bCk+eaCZKZfBg8YdDCkPwpNu4nGkAyI0t99xM pNl2yaEeIaRfzNz4/OOZUYQ3inLLTYUQHLN5PJKCiLZNbjACnKaLaeZFIGx8qwzT/yasYS Ozb3M9vGY2DwkZXyU1sJWde+4bhDny1m/Vdcd5WMB3t6e3aIqDghruNlL1saaue321mA57 G6DlYhFqibYGmnkJGRFEh1e4wF3sj0E4eUfQ98+JPx3pNo8MAZD6OwCcllHpznB557Lsfn FQmktBcRH47SQOFI5kvpzi5GRxmJZ+GAJpH1RPQuPK7Nwn0BGemNkYNgtCLrEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770737593; a=rsa-sha256; cv=none; b=hI6uJyfpDT0TESmhEacagNaDJfXRxhzJbEQYaeD3VM9vJscSvr1zVV8dg0nUpgnzvWdPeT Q5CIhEyPnyL6UcSNieLYiqATe4rBe77r4t5SdKae0AWIGUWQa2CpxQMGJp0hlEJ1AW15qY Y3x8u4zCRLO5efJ5HXeAvpCsm5Gf4rCUDlu6tU1nA1tSGojZnQhOJ4RDPBpVfcxnMkuRWp W35f8tOi6ywEfUtQeMlqj3HsQNoDJC6chqcnEOauFDmnN482s2x0OhNkNjePzCf48SuiJw VmYjSXNGtFk0G2c4lhBqR1W1UDvBMKy2MasZ5Jg6X2BYresay4+GyNvdL1BLUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eIrFzy/+N6UpnWFqpWR5pLuHo0YPUtFUZNnEnRjEw54=; b=d8XTHi1yz5/wib3di6hglgMzmxW0GJliRfDeIkCBezHEwnfNq1JZzoNrnJK7QSbG4IeXkX w6Rm4IkSceP7a6YrppM0L7NCyDi7e/7A4yf2M4J5+b16970NYKu+gt6p/lKUPTr+g+xrrB raZKf7zEEshgH19e55yaDuRPJC5yd8WliWdq7gpfBNKjeCssUf/SHGgTrR5BDA1qqzqYRv RDCZS/eEtiHspdVThA9DL6/CzKRhLpKqnQbhG3JAiavsjEYFWWj4Un05d65igw860n6UNR ldmYPw5adKobBF1GLVapIQWTd0cRDIWfNINjekSKgTdz0SOaxUtC9uxM9iJuJw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9QZ12t8xz1NXx for ; Tue, 10 Feb 2026 15:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47176 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 15:33:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: f0852209a086 - stable/13 - diff: Add test case for pagination resource leak List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f0852209a086387d8171da58a09faadaf5b0a455 Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 15:33:08 +0000 Message-Id: <698b4fb4.47176.21bc99b0@gitrepo.freebsd.org> The branch stable/13 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f0852209a086387d8171da58a09faadaf5b0a455 commit f0852209a086387d8171da58a09faadaf5b0a455 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-10 15:32:47 +0000 diff: Add test case for pagination resource leak The pagination code leaks either processes or descriptors or both, depending on the exact version of the code you have. Add a test case which exercises this leak to facilitate fixing it. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55111 (cherry picked from commit 270492602b9bd8b8fce4f021f055804978bf3f23) --- usr.bin/diff/tests/diff_test.sh | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 8b8846925ee8..181463ca9be7 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -328,6 +328,26 @@ bigu_body() diff -U$(((1<<31)-2)) a b } +prleak_head() +{ + atf_set "descr" "Verify that pagination does not leak resources" +} +prleak_body() +{ + local n=32 + mkdir a b + for hi in $(jot -w%02x $n 0) ; do + mkdir a/$hi b/$hi + for lo in $(jot -w%02x $n 0) ; do + echo "$hi$lo" >a/$hi/$lo + echo "$hi$lo" >b/$hi/$lo + done + done + ulimit -n 1000 + ulimit -u 1000 + atf_check diff -rul a b +} + atf_init_test_cases() { atf_add_test_case simple @@ -353,4 +373,5 @@ atf_init_test_cases() atf_add_test_case dirloop atf_add_test_case bigc atf_add_test_case bigu + atf_add_test_case prleak }