From owner-cvs-src@FreeBSD.ORG  Sat Mar 31 20:48:43 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8232C16A402;
	Sat, 31 Mar 2007 20:48:43 +0000 (UTC) (envelope-from bde@zeta.org.au)
Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B9A313C4BF;
	Sat, 31 Mar 2007 20:48:43 +0000 (UTC) (envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.2.163])
	by mailout2.pacific.net.au (Postfix) with ESMTP id 055796E516;
	Sun,  1 Apr 2007 06:48:37 +1000 (EST)
Received: from besplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailproxy2.pacific.net.au (Postfix) with ESMTP id 07D3E27416;
	Sun,  1 Apr 2007 06:48:40 +1000 (EST)
Date: Sun, 1 Apr 2007 06:48:39 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@besplex.bde.org
To: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: <200703311608.l2VG8oNE086672@repoman.freebsd.org>
Message-ID: <20070401064404.B9096@besplex.bde.org>
References: <200703311608.l2VG8oNE086672@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_lookup.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Mar 2007 20:48:43 -0000

On Sat, 31 Mar 2007, Robert Watson wrote:

> rwatson     2007-03-31 16:08:50 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             vfs_lookup.c
>  Log:
>  Rather than ignoring any error return from getnewvnode() in nameiinit(),
>  explicitly test and panic.  This should not ever happen, but if it does,
>  this is a preferred failure mode to a NULL pointer dereference in kernel.

No, a null pointer dereference is far preferable since it takes less code
and is easier to debug.

Bruce