From owner-svn-src-all@FreeBSD.ORG  Thu Feb  5 18:23:43 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF0EA10656C2;
	Thu,  5 Feb 2009 18:23:43 +0000 (UTC)
	(envelope-from niclas.zeising@gmail.com)
Received: from mx6.bahnhof.se (mx6.bahnhof.se [213.80.101.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 920B28FC1E;
	Thu,  5 Feb 2009 18:23:43 +0000 (UTC)
	(envelope-from niclas.zeising@gmail.com)
Received: from localhost (mx6.local [127.0.0.1])
	by mx6-reinject (Postfix) with ESMTP id 393222110B0;
	Thu,  5 Feb 2009 18:56:08 +0100 (CET)
Received: from mx6.bahnhof.se ([127.0.0.1])
	by localhost (mx6.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 62680-02; Thu,  5 Feb 2009 18:56:04 +0100 (CET)
Received: from [10.0.0.3] (h-85-24-219-30.NA.cust.bahnhof.se [85.24.219.30])
	by mx6.bahnhof.se (Postfix) with ESMTP id 9CF3F21106B;
	Thu,  5 Feb 2009 18:56:04 +0100 (CET)
Received: from 127.0.0.1 (AVG SMTP 8.0.233 [270.10.18/1935]);
	Thu, 05 Feb 2009 18:55:54 +0100
Message-ID: <498B2829.9000608@gmail.com>
Date: Thu, 05 Feb 2009 18:55:53 +0100
From: Niclas Zeising <niclas.zeising@gmail.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: Warner Losh <imp@FreeBSD.org>
References: <200902051743.n15HhCMx033130@svn.freebsd.org>
In-Reply-To: <200902051743.n15HhCMx033130@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MX6)
X-Spam-Status: No, score=1.708 tagged_above=-99 required=5
	tests=[DNS_FROM_RFC_POST=1.708]
X-Spam-Score: 1.708
X-Spam-Level: *
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r188154 - head/sys/opencrypto
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Feb 2009 18:23:44 -0000

Warner Losh wrote:
> Author: imp
> Date: Thu Feb  5 17:43:12 2009
> New Revision: 188154
> URL: http://svn.freebsd.org/changeset/base/188154
> 
> Log:
>   Fix return type for detach routine (should be int)
>   Fix first parameter for identify routine (should be driver_t *)
> 
> Modified:
>   head/sys/opencrypto/cryptosoft.c
> 
> Modified: head/sys/opencrypto/cryptosoft.c
> ==============================================================================
> --- head/sys/opencrypto/cryptosoft.c	Thu Feb  5 15:09:42 2009	(r188153)
> +++ head/sys/opencrypto/cryptosoft.c	Thu Feb  5 17:43:12 2009	(r188154)
> @@ -986,7 +986,7 @@ done:
>  }
>  
>  static void
> -swcr_identify(device_t *dev, device_t parent)
> +swcr_identify(driver_t *drv, device_t parent)
                            ^^^

Was this name change intentional?

>  {
>  	/* NB: order 10 is so we get attached after h/w devices */
>  	if (device_find_child(parent, "cryptosoft", -1) == NULL &&
> @@ -1040,12 +1040,13 @@ swcr_attach(device_t dev)
>  	return 0;
>  }
>  
> -static void
> +static int
>  swcr_detach(device_t dev)
>  {
>  	crypto_unregister_all(swcr_id);
>  	if (swcr_sessions != NULL)
>  		free(swcr_sessions, M_CRYPTO_DATA);
> +	return 0;
>  }
>  
>  static device_method_t swcr_methods[] = {

Regards!
//Niclas