From owner-svn-src-head@FreeBSD.ORG Wed Jun 13 15:40:05 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C5AFD1065673; Wed, 13 Jun 2012 15:40:05 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 69D378FC25; Wed, 13 Jun 2012 15:40:05 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id E5135640; Wed, 13 Jun 2012 17:40:03 +0200 (CEST) Date: Wed, 13 Jun 2012 17:38:09 +0200 From: Pawel Jakub Dawidek To: Mateusz Guzik Message-ID: <20120613153809.GB1399@garage.freebsd.pl> References: <20120612114335.GA1372@garage.freebsd.pl> <20120612134950.GC20749@dft-labs.eu> <20120612160128.GA1429@garage.freebsd.pl> <20120612191828.GD20749@dft-labs.eu> <20120612214400.GB1429@garage.freebsd.pl> <20120613093807.GA3893@dft-labs.eu> <20120613102900.GD1386@garage.freebsd.pl> <20120613105344.GB3893@dft-labs.eu> <20120613111309.GE1386@garage.freebsd.pl> <20120613111853.GC3893@dft-labs.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rJwd6BRFiFCcLxzm" Content-Disposition: inline In-Reply-To: <20120613111853.GC3893@dft-labs.eu> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: svn commit: r236935 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2012 15:40:06 -0000 --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 13, 2012 at 01:18:53PM +0200, Mateusz Guzik wrote: > On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote: > > On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > >=20 > > > David reported that previous version of the patch fixed panic he was > > > experiencing, so I consider the patch tested. > >=20 > > Looks good, one (hopefully last) minor nit. I'd change this comment: > >=20 > > * Search the bitmap for a free descriptor starting at minfd. If none > > * is found, try to grow the file table. > >=20 > > To something like this: > >=20 > > * Search the bitmap for a free descriptor starting at minfd. > > * If none is found, grow the file table. > >=20 > > 'try' is a bit misleading for my taste, as it suggest that growing the > > file table might fail, I think. > >=20 >=20 > Done in: > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free6.patch Perfect:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --rJwd6BRFiFCcLxzm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/Ys94ACgkQForvXbEpPzTvuwCghGhiwc8dYyujbKPL/R5WaMHl +2QAoKqhApCORVHHGVUOzFtzKeNPB7cm =XJ4k -----END PGP SIGNATURE----- --rJwd6BRFiFCcLxzm--