From owner-cvs-all Mon Jun 21 0:12:30 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id DF09B14CC0; Mon, 21 Jun 1999 00:12:21 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 988BB75; Mon, 21 Jun 1999 15:12:11 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.0.2 2/24/98 To: Doug Rabson Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/isa sio.c In-reply-to: Your message of "Sun, 20 Jun 1999 14:28:22 +0100." Date: Mon, 21 Jun 1999 15:12:11 +0800 From: Peter Wemm Message-Id: <19990621071211.988BB75@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Doug Rabson wrote: > On Sun, 20 Jun 1999, Peter Wemm wrote: > > > peter 1999/06/20 06:10:11 PDT > > > > Modified files: > > sys/isa sio.c > > Log: > > Use the proper interfaces to find if a device is enabled, don't dig into > > the bus mechanism's private internals! > > Well spotted. For future reference, bus_private.h may not be included by > any drivers. Any driver which includes this header should be considered > broken. Well, I wouldn't go quite that far.. Usually this would be the case, the whole point of the bus interface system is to avoid structures for this sort of thing and diving in severely impairs binary upwards compatability. If a driver or bus genuinely *does* need to get to the internals, then either the programmer is attacking the problem the wrong way or the public interfaces are inadequate. For actual bus devices, it is not all that unlikely that there are weaknesses. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message