From owner-freebsd-current@FreeBSD.ORG  Fri Nov 12 09:07:40 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 197DF1065675
	for <freebsd-current@freebsd.org>; Fri, 12 Nov 2010 09:07:40 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe07.swip.net [212.247.154.193])
	by mx1.freebsd.org (Postfix) with ESMTP id 9DA168FC1C
	for <freebsd-current@freebsd.org>; Fri, 12 Nov 2010 09:07:39 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.1 cv=sEolSJAlcSxSMaOm1MQ0bvrIu+BNAN+OqG2UAUgC4Ok=
	c=1 sm=1 a=WrOSKJTHxIAA:10 a=8nJEP1OIZ-IA:10 a=CL8lFSKtTFcA:10
	a=i9M/sDlu2rpZ9XS819oYzg==:17 a=NfZfBIl9gYmS0lq_rVEA:9
	a=sVW8itN138z2eO1VaZuicetP3xIA:4 a=wPNLvfGTeEIA:10
	a=i9M/sDlu2rpZ9XS819oYzg==:117
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 48026953; Fri, 12 Nov 2010 10:07:37 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-current@freebsd.org
Date: Fri, 12 Nov 2010 10:08:41 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.4.5; amd64; ; )
References: <06D5F9F6F655AD4C92E28B662F7F853E039E389A@seaxch09.desktop.isilon.com>
	<201011121006.10183.hselasky@c2i.net>
In-Reply-To: <201011121006.10183.hselasky@c2i.net>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(
	=?iso-8859-1?q?=3B=5FIjlA=3A=0A=09hGE=2E=2EEw?=,
	=?iso-8859-1?q?XAQ*o=23=5C/M=7ESC=3DS1-f9=7BEzRfT=27=7CHhll5Q=5Dha5Bt-s=7Co?=
	=?iso-8859-1?q?TlKMusi=3A1e=5BwJl=7Dkd=7DGR=0A=09Z0adGx-x=5F0zGbZj=27e?=(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011121008.41122.hselasky@c2i.net>
Cc: Matthew Fleming <matthew.fleming@isilon.com>
Subject: Re: sleep bug in taskqueue(9)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Nov 2010 09:07:40 -0000

On Friday 12 November 2010 10:06:10 you wrote:
> -               queue->tq_running = NULL;

forgot this check:

		/* don't clear if queued again */
		if (task->ta_entry.tqe_prev == (void *)1)
> +               task->ta_entry.tqe_prev = (void *)0;
>                 wakeup(task);