From owner-cvs-src@FreeBSD.ORG Fri Apr 9 11:19:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FBA716A4CE; Fri, 9 Apr 2004 11:19:42 -0700 (PDT) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14E8C43D58; Fri, 9 Apr 2004 11:19:39 -0700 (PDT) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) i39IJcWc082250; Fri, 9 Apr 2004 19:19:38 +0100 (BST) (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost)i39IJc4k082249; Fri, 9 Apr 2004 19:19:38 +0100 (BST) (envelope-from mark@grondar.org) X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1])i39IGt0w060367; Fri, 9 Apr 2004 19:16:55 +0100 (BST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200404091816.i39IGt0w060367@grimreaper.grondar.org> To: Nate Lawson In-Reply-To: Your message of "Fri, 09 Apr 2004 10:25:14 PDT." <20040409102152.I48723@root.org> Date: Fri, 09 Apr 2004 19:16:55 +0100 Sender: mark@grondar.org X-Spam-Score: 4 (****) FROM_NO_LOWER,MSGID_FROM_MTA_SHORT X-Scanned-By: MIMEDefang 2.39 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Mark Murray cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2004 18:19:42 -0000 Nate Lawson writes: > If you're going to add support for either, please don't do it as OpenBSD > did with spamming identcpu.c with a hardware driver. We've already > extracted longrun support from identcpu.c and going the other way would be > a huge error. Wasn't planning to. I already chatted to Peter about this. The worst I was intending to do was set flags in identcpu.c for use later, but Peter convinced me that repeating the cpuid() dance at a later point wasn't a bad idea. > Also, I'd like to review any code if you plan to commit some. The RNG driver is in sys/dev/random. :-) M -- Mark Murray iumop ap!sdn w,I idlaH