Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Feb 2015 22:16:47 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        NGie Cooper <yaneurabeya@gmail.com>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r278223 - head/lib/clang
Message-ID:  <7338E032-8668-44D2-AE98-C3E50E512DDD@FreeBSD.org>
In-Reply-To: <CAGHfRMCKxHXpnr38orBiWMEpXsgAVhZ1ViOcdswGEezRvnKoVw@mail.gmail.com>
References:  <201502042100.t14L0Ued055489@svn.freebsd.org> <CAGHfRMCKxHXpnr38orBiWMEpXsgAVhZ1ViOcdswGEezRvnKoVw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 04 Feb 2015, at 22:09, NGie Cooper <yaneurabeya@gmail.com> wrote:
> 
> On Wed, Feb 4, 2015 at 1:00 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> Author: dim
>> Date: Wed Feb  4 21:00:29 2015
>> New Revision: 278223
>> URL: https://svnweb.freebsd.org/changeset/base/278223
>> 
>> Log:
>>  For now, add -stdlib=libc++ to the flags for building clang, since that
>>  makes it easier to build head on stable/9, where libstdc++ is still the
>>  default.  We can revisit this when somebody will try to build base with
>>  gcc 4.8.1 or higher, and its included libstdc++.
> 
> Maybe this should be conditionalized on COMPILER_TYPE?

COMPILER_TYPE doesn't say anything about the C++ library used.  Maybe we
need a CXX_LIBRARY_TYPE setting for it?

That said, you may be right that it should be conditionalized on the
compiler type anyway, since gcc does not support the -stdlib= option.

-Dimitry


--Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.26

iEYEARECAAYFAlTSjEIACgkQsF6jCi4glqP4RQCdFNVHO/UigCPBnBQ1kf86e6e7
1PMAn3fWQ0knM5I8iotG4/kQyinHCuP2
=lqhD
-----END PGP SIGNATURE-----

--Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7338E032-8668-44D2-AE98-C3E50E512DDD>